[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-03-05 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 5: Code-Review+1 LGTM.I can't +2 it. Michael/Joe w

[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-03-01 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] [DOCS] Add HADOOP-15720 to the list of Known Issues

2019-02-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12631 ) Change subject: [DOCS] Add HADOOP-15720 to the list of Known Issues .. Patch Set 1: (3 comments) Hi Alex, Thanks for doing this!

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 7: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 5: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 4: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 3: (3 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12593 ) Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps .. IMPALA-8245: Add hostname to the error message

[Impala-ASF-CR] IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps

2019-02-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12593 Change subject: IMPALA-8245: Add hostname to the error message in HdfsMonitoredOps .. IMPALA-8245: Add hostname to the error message

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-25 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12583 Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. IMPALA-5397: Set query's end_time_us_ when the

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_M

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12560 Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

2019-02-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12478 Change subject: IMPALA-8189: Disable flaky scanner test on S3 .. IMPALA-8189: Disable flaky scanner test on S3 TestParquet::test_res

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 3: > Patch Set 3: > > Totally fo

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 3: (1 comment) > Patch Set 2: >

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. IMPALA-8064: Improve observability of wait ti

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. IMPALA-8064: Improve observability of wait ti

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-07 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12401 Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. IMPALA-8064: Improve observability of wait t

[Impala-ASF-CR] IMPALA-8172: [DOCS] Documented the NUM ROWS PRODUCED LIMIT query option

2019-02-07 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12396 ) Change subject: IMPALA-8172: [DOCS] Documented the NUM_ROWS_PRODUCED_LIMIT query option .. Patch Set 1: Code-Review+1 Looks good,

[Impala-ASF-CR] IMPALA-8096: Add rows produced limit per query

2019-02-07 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows produced limit per query .. IMPALA-8096: Add rows produced limit per query This patch limits th

[Impala-ASF-CR] IMPALA-8096: Add rows produced limit per query

2019-02-07 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows produced limit per query .. IMPALA-8096: Add rows produced limit per query This patch limits th

[Impala-ASF-CR] IMPALA-8096: Add rows produced limit per query

2019-02-07 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows produced limit per query .. Patch Set 5: Code-Review+1 (1 comment) Carry forward Bikram's +1

[Impala-ASF-CR] IMPALA-8096: Add rows produced limit per query

2019-02-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows produced limit per query .. IMPALA-8096: Add rows produced limit per query This patch limits th

[Impala-ASF-CR] IMPALA-8096: Add rows returned limit per query

2019-02-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows returned limit per query .. Patch Set 3: Rebased on master. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8096: Add rows returned limit per query

2019-02-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows returned limit per query .. IMPALA-8096: Add rows returned limit per query This patch limits th

[Impala-ASF-CR] IMPALA-8096: Add rows returned limit per query

2019-02-06 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12328 Change subject: IMPALA-8096: Add rows returned limit per query .. IMPALA-8096: Add rows returned limit per query This patch limits t

[Impala-ASF-CR] IMPALA-8162: Add memory reserved and admitted to the backends debug page

2019-02-05 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12364 ) Change subject: IMPALA-8162: Add memory reserved and admitted to the backends debug page .. Patch Set 1: Code-Review+1 (3 comments

[Impala-ASF-CR] IMPALA-8151: Use sizeof() in HiveUdfCall to specify non-primitive type's size

2019-02-04 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12355 Change subject: IMPALA-8151: Use sizeof() in HiveUdfCall to specify non-primitive type's size .. IMPALA-8151: Use sizeof() in HiveUd

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 4: Code-Review+1 (5 comments) Hi Bikram, This lo

[Impala-ASF-CR] IMPALA-6932: Speed up scans for sequence datasets with many files

2019-01-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11517 ) Change subject: IMPALA-6932: Speed up scans for sequence datasets with many files .. IMPALA-6932: Speed up scans for sequence dataset

[Impala-ASF-CR] IMPALA-8007: Fix test slow subscriber

2019-01-10 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12216 Change subject: IMPALA-8007: Fix test_slow_subscriber .. IMPALA-8007: Fix test_slow_subscriber Previously, test_slow_subscriber veri

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-10 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 3: > Patch Set 3:

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-10 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 2: Code-Review+1 Hi Joe, I can't +2 t

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070: Disabl

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 3: (1 comment) ht

[Impala-ASF-CR] IMPALA-8063: Add sleep to ImpalaTestSuite::wait for state() loop

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12207 ) Change subject: IMPALA-8063: Add sleep to ImpalaTestSuite::wait_for_state() loop .. Patch Set 1: Looks good. Can you also reduce th

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070: Disabl

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 2: (2 comments) h

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-09 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12203 Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. IMPALA-6544/IMPALA-7070: Disab

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-04 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 7: Code-Review+1 (1 comment) > Patch Set 6: > > (5 c

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-03 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 6: (4 comments) Looks good. I just have a few questi

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2019-01-02 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: > Patch Set 3: > > The dis

[Impala-ASF-CR] IMPALA-7811: optionally count JVM heap towards process mem limit

2018-12-03 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10928 ) Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit .. Patch Set 10: Code-Review+1 (1 comment) Looks

[Impala-ASF-CR] IMPALA-7882: Remove StringValue padding validation

2018-11-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11989 ) Change subject: IMPALA-7882: Remove StringValue padding validation .. Patch Set 1: > Patch Set 1: Code-Review+1 > > Make sense to m

[Impala-ASF-CR] IMPALA-7882: Remove StringValue padding validation

2018-11-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11989 Change subject: IMPALA-7882: Remove StringValue padding validation .. IMPALA-7882: Remove StringValue padding validation Previously,

[Impala-ASF-CR] IMPALA-7811: optionally count JVM heap towards process mem limit

2018-11-20 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10928 ) Change subject: IMPALA-7811: optionally count JVM heap towards process mem limit .. Patch Set 8: (5 comments) The approach used to

[Impala-ASF-CR] IMPALA-7873: Fix flakiness in TestExchangeMemUsage

2018-11-20 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11965 Change subject: IMPALA-7873: Fix flakiness in TestExchangeMemUsage .. IMPALA-7873: Fix flakiness in TestExchangeMemUsage IMPALA-7367

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 7: > Patch Set 7: > > I can submit once you pu

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-15 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-14 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 3: > Patch Set 2: > > > Patch Set 2: > > > > >

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 2: > Patch Set 2: > > Build Failed > > https:/

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11599 Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots T

[Impala-ASF-CR] IMPALA-7791: Compute AggregationNode's estimated rows using # instances

2018-11-05 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11854 ) Change subject: IMPALA-7791: Compute AggregationNode's estimated rows using # instances .. Patch Set 2: > Patch Set 2: > > have yo

[Impala-ASF-CR] IMPALA-7791: Compute AggregationNode's estimated rows using # instances

2018-11-02 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11854 ) Change subject: IMPALA-7791: Compute AggregationNode's estimated rows using # instances .. IMPALA-7791: Compute AggregationNode's est

[Impala-ASF-CR] IMPALA-7791: Compute AggregationNode's estimated rows using # instances

2018-11-01 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11854 Change subject: IMPALA-7791: Compute AggregationNode's estimated rows using # instances .. IMPALA-7791: Compute AggregationNode's es

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11828 ) Change subject: IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong() .. IMPALA-7363: Fix buffer usage in ScannerConte

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11828 ) Change subject: IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong() .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11828 Change subject: IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong() .. IMPALA-7363: Fix buffer usage in ScannerCont

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: This can't be tested on hd

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: I haven't yet tested this

[Impala-ASF-CR] IMPALA-7735: Expose queuing status in ExecSummary and impala-shell

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11816 ) Change subject: IMPALA-7735: Expose queuing status in ExecSummary and impala-shell .. Patch Set 1: Code-Review+1 (1 comment) http

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. Patch Set 2: (2 comments) http:

[Impala-ASF-CR] IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality

2018-10-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11806 ) Change subject: IMPALA-7749: Compute AggregationNode's memory estimate using input cardinality .. IMPALA-7749: Compute AggregationNod

[Impala-ASF-CR] IMPALA-7749: (Part 1/2) Improve AggregationNode's memory estimates

2018-10-26 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11806 Change subject: IMPALA-7749: (Part 1/2) Improve AggregationNode's memory estimates .. IMPALA-7749: (Part 1/2) Improve AggregationNod

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. [WIP] IMPALA-6932: Speed up scans for sequ

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-22 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: (4 comments) http://gerri

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. [WIP] IMPALA-6932: Speed up scans for sequ

[Impala-ASF-CR] IMPALA-7545: Add queuing reason to query log

2018-10-15 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queuing reason to query log .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/1166

[Impala-ASF-CR] IMPALA-7545: Add queuing reason to query log

2018-10-15 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queuing reason to query log .. IMPALA-7545: Add queuing reason to query log After this change, the H

[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log

2018-10-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, the

[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log

2018-10-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/116

[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log

2018-10-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11669 ) Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, the

[Impala-ASF-CR] IMPALA-7545: Add queueing reason to query log

2018-10-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11669 Change subject: IMPALA-7545: Add queueing reason to query log .. IMPALA-7545: Add queueing reason to query log After this change, th

[Impala-ASF-CR] IMPALA-7690: Make test pool config change while queued compatible with python 2.6

2018-10-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11660 ) Change subject: IMPALA-7690: Make test_pool_config_change_while_queued compatible with python 2.6 .. Patch Set 1: Code-Review+1 Hi

[Impala-ASF-CR] IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"

2018-10-08 Thread Pooja Nilangekar (Code Review)
Hello Thomas Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11616 to look at the new patch set (#2). Change subject: IMPALA-7678: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver" ..

[Impala-ASF-CR] Revert "IMPALA-7660: Support ECDH ciphers for debug webserver"

2018-10-08 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11616 Change subject: Revert "IMPALA-7660: Support ECDH ciphers for debug webserver" .. Revert "IMPALA-7660: Support ECDH ciphers for debug

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-09-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11517 Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. [WIP] IMPALA-6932: Speed up scans for seq

[Impala-ASF-CR] IMPALA-7352: Account for clustering in HdfsTableSink

2018-09-24 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11485 ) Change subject: IMPALA-7352: Account for clustering in HdfsTableSink .. IMPALA-7352: Account for clustering in HdfsTableSink Previous

[Impala-ASF-CR] IMPALA-7352: Account for clustering in HdfsTableSink

2018-09-24 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11485 ) Change subject: IMPALA-7352: Account for clustering in HdfsTableSink .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7352: Account for clustering in HdfsTableSink

2018-09-20 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11485 Change subject: IMPALA-7352: Account for clustering in HdfsTableSink .. IMPALA-7352: Account for clustering in HdfsTableSink Previou

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-09-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. IMPALA-7335: Fix a race in HdfsScanNode This change fixes the race between

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-09-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/11337/6/be

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-09-17 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. IMPALA-7335: Fix a race in HdfsScanNode This change fixes the race between

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-09-17 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/11337/6/b

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-09-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. IMPALA-7335: Fix a race in HdfsScanNode This change fixes the race between

[Impala-ASF-CR] IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded

2018-08-30 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11369 ) Change subject: IMPALA-7517. Fix hang in scanner threads when soft limit is exceeded .. Patch Set 1: Code-Review+1 (1 comment) ht

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-08-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. IMPALA-7335: Fix a race in HdfsScanNode This change fixes the race between

[Impala-ASF-CR] IMPALA-7335: Fix a race in HdfsScanNode

2018-08-29 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11337 ) Change subject: IMPALA-7335: Fix a race in HdfsScanNode .. Patch Set 3: > Patch Set 3: > > (1 comment) Modifying the SetDoneIntern

  1   2   3   >