[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Clean up generation of XML configuration files hive-site.xml a

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/12930/2

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, Adam Holley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12930 to look at the new patch set (#3). Change subject: Clean up generation of XML configuration files .

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/2

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: Code-Review+1 (1 comment) Just a question relate

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (5 comments) Ok no worries, yeah that makes sense. You

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: Thanks. I think for this case the "long lines" are probab

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: If you want, you can prefetch the bot comments with

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-04 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, Adam Holley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12930 to look at the new patch set (#2). Change subject: Clean up generation of XML configuration files .

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 1: Build Failed https://jenkins.impala.io/job/ger

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-03 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12930 to review the following change. Change subject: Clean up generation of XML configuration files .. Clean up ge

[Impala-ASF-CR] Clean up generation of XML configuration files

2019-04-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 ) Change subject: Clean up generation of XML configuration files .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/