[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/273/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 17 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 18:29:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/272/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 17 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 18:13:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. Reviewed-on: http://gerrit.cloudera.org:8080/10066 Tested-by: Impala Public JenkinsReviewed-by: Alex Rodoni --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 846 insertions(+), 704 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Rodoni: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 17 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 16 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 18:13:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 16 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 18:11:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/271/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 16 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 18:03:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#16). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 846 insertions(+), 704 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/16 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 16 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 15 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:44:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 15: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/270/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 15 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:41:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 15 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:36:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml@390 PS14, Line 390: If there is enough precision but not enough scale in the destination, Impala rounds > Not correct. Impala does not round for assignments. Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 14 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:32:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#15). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 849 insertions(+), 704 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/15 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 15 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/14/docs/topics/impala_decimal.xml@390 PS14, Line 390: If there is enough precision but not enough scale in the destination, Impala rounds Not correct. Impala does not round for assignments. Assignments require enough scale *and* precision. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 14 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:22:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#14). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 855 insertions(+), 704 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/14 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 14 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@197 PS13, Line 197: > Let's move and replace this paragraph with the one on L208. Done http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@209 PS13, Line 209: Note that in memory and on disk for binary file formats, such as Parquet or Avro, > This is not quite accurate and redundant with L197. Let's replace this para Done http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@395 PS13, Line 395: > These points are not correct. For assignments, Impala is very strict. If th Made the second point clear. And changed "leading digits" to "precision". http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@431 PS13, Line 431: DECIMAL. An error returns. > An error is returned. Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 13 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 17:08:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 13: (4 comments) Looks good, last round http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@197 PS13, Line 197: Let's move and replace this paragraph with the one on L208. http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@209 PS13, Line 209: Note that in memory and on disk for binary file formats, such as Parquet or Avro, This is not quite accurate and redundant with L197. Let's replace this paragraph as mentioned above. http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@395 PS13, Line 395: These points are not correct. For assignments, Impala is very strict. If the destination does not have enough precision, then Impala returns an error. No rounding is performed at all. http://gerrit.cloudera.org:8080/#/c/10066/13/docs/topics/impala_decimal.xml@431 PS13, Line 431: DECIMAL. An error returns. An error is returned. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 13 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 30 Apr 2018 16:32:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#13). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 870 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/13 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 13 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@879 PS10, Line 879: Any values that do not fit within the new precision and scale are returned as > Taras, is this really true? I would have expected that we round or error. Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 04:44:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@50 PS10, Line 50: This data type is suitable for financial and other arithmetic calculations where the > We should have a better introduction. We would not be comparing it to FLOAT Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@56 PS10, Line 56: The key differences between this version of DECIMAL and the previous > We should move this table to the bottom. Instead of calling it DECIMAL_V1 a Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@293 PS10, Line 293: If the precision of the result would be greater than 38, Impala truncates the result from > Done Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@293 PS10, Line 293: If the precision of the result would be greater than 38, Impala truncates the result from > yes, "truncates and rounds" Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@668 PS10, Line 668: expressions to DECIMAL as long as the overall number of digits and digits > Done Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 04:43:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#12). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 872 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/12 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 12 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@280 PS10, Line 280: Precision and scale in arithmetic operations and UNION: > I think we should have a separate section for decimal assignments where the Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@293 PS10, Line 293: If the precision of the result would be greater than 38, Impala truncates the result from > truncates and rounds, right Taras? Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@544 PS10, Line 544: DECIMAL cannot be implicitly converted to DECIMAL if > I'd phrase this positively, i.e. describe in which cases the conversion is Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@668 PS10, Line 668: expressions to DECIMAL as long as the overall number of digits and digits > Sentence seem wrong. We follow same general procedure here, round from the Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 01:16:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#11). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 864 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/11 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 11 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: Alex and Tara, Please review the changes in the latest patch. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 01:16:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@50 PS10, Line 50: This data type is suitable for financial and other arithmetic calculations where the We should have a better introduction. We would not be comparing it to FLOAT. We should not mention that it's suitable for financial purposes. How about this: Precision is the maximum number of decimal digits and scale is the number of digits to the right of the decimal point. The data type is useful for storing and doing operations on precise decimal values. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@56 PS10, Line 56: The key differences between this version of DECIMAL and the previous We should move this table to the bottom. Instead of calling it DECIMAL_V1 and DECIMAL_v2 we should say "Decimal in Impala 2.x" and "Decimal in Impala 3.x". Say that the old behavior can be enabled by disabling the query option "set decimal_v2=false" http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@293 PS10, Line 293: If the precision of the result would be greater than 38, Impala truncates the result from > truncates and rounds, right Taras? yes, "truncates and rounds" Let's make a separate section called "Decimal Assignment" as Alex mentioned and put UNION in that section. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@668 PS10, Line 668: expressions to DECIMAL as long as the overall number of digits and digits > Taras? Alex is right. This contradicts what it says on line 678. should be "... as number fits within the specified target DECIMAL type without overflow" http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@879 PS10, Line 879: Any values that do not fit within the new precision and scale are returned as > Taras, is this really true? I would have expected that we round or error. No, we do not round. We will error if the query option ABORT_ON_ERROR is set to true. If that option is set to FALSE, we will get a NULL and warning that conversion failed. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 01:09:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (14 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@271 PS10, Line 271: Note that in memory and on disk for binary file formats such as Parquet or Avro, > This seems to contradict what L262 says which claims that binary formats wi This is a note about decimal(9) and decimal (10) - the difference in storage bytes. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@284 PS10, Line 284: Unlike other numeric types, memory footprint of DECIMAL can increase as a > I don't think this is correct or even needed. Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@289 PS10, Line 289: For all arithmetic options, the resulting precision is maximum of 38. > is at most 38 Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@523 PS10, Line 523: FLOAT when necessary even with a loss of precision. It can be > loss of precision -> loss of information Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@545 PS10, Line 545: > Add this: Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@613 PS10, Line 613: DOUBLE), Impala raises an error and does not convert the value. > does not implicitly convert the value. Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@618 PS10, Line 618: DECIMAL and other types in INSERT statements: > in decimal assignments like in INSERT and UNION statements or functions lik Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@668 PS10, Line 668: expressions to DECIMAL as long as the overall number of digits and digits > Sentence seem wrong. We follow same general procedure here, round from the Taras? http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@690 PS10, Line 690: DECIMAL, an error returns. > an error is returned Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@710 PS10, Line 710: Casting any non-numeric value, such as 'ABC', or NULL to > Casting NULL to a decimal is allowed. Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@724 PS10, Line 724: DECIMAL vs FLOAT or DOUBLE consideration: > DECIMAL vs. FLOAT considerations: Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@728 PS10, Line 728: The FLOAT and DOUBLE type numbers can cause problems or > type numbers -> types Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@732 PS10, Line 732: values for GROUP BY columns. The DECIMAL values can help > The DECIMAL type Done http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@934 PS10, Line 934: Because DECIMAL type has a fixed size, the maximum and average size > the DECIMAL type Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 28 Apr 2018 00:04:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (18 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@271 PS10, Line 271: Note that in memory and on disk for binary file formats such as Parquet or Avro, This seems to contradict what L262 says which claims that binary formats will use fewer bytes. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@280 PS10, Line 280: Precision and scale in arithmetic operations and UNION: I think we should have a separate section for decimal assignments where the implicit decimal->decimal conversions are strict. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@284 PS10, Line 284: Unlike other numeric types, memory footprint of DECIMAL can increase as a I don't think this is correct or even needed. If we add two INTs we get a BIGINT, so that also increases the memory footprint. I suggest removing this paragraph. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@289 PS10, Line 289: For all arithmetic options, the resulting precision is maximum of 38. is at most 38 http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@293 PS10, Line 293: If the precision of the result would be greater than 38, Impala truncates the result from truncates and rounds, right Taras? This is also not quite right for UNION, so I think it's better to have a separate section for decimal assignment. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@512 PS10, Line 512: Impala enforces strict conversion rules in INSERT statements or This section seems to be for "decimal assignment" like I mentioned above. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@523 PS10, Line 523: FLOAT when necessary even with a loss of precision. It can be loss of precision -> loss of information http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@544 PS10, Line 544: DECIMAL cannot be implicitly converted to DECIMAL if I'd phrase this positively, i.e. describe in which cases the conversion is allowed. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@613 PS10, Line 613: DOUBLE), Impala raises an error and does not convert the value. does not implicitly convert the value. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@618 PS10, Line 618: DECIMAL and other types in INSERT statements: in decimal assignments like in INSERT and UNION statements or functions like COALESCE() http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@668 PS10, Line 668: expressions to DECIMAL as long as the overall number of digits and digits Sentence seem wrong. We follow same general procedure here, round from the back or error if there are not enough digits before the decimal point. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@690 PS10, Line 690: DECIMAL, an error returns. an error is returned http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@710 PS10, Line 710: Casting any non-numeric value, such as 'ABC', or NULL to Casting NULL to a decimal is allowed. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@724 PS10, Line 724: DECIMAL vs FLOAT or DOUBLE consideration: DECIMAL vs. FLOAT considerations: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@728 PS10, Line 728: The FLOAT and DOUBLE type numbers can cause problems or type numbers -> types http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@732 PS10, Line 732: values for GROUP BY columns. The DECIMAL values can help The DECIMAL type http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@879 PS10, Line 879: Any values that do not fit within the new precision and scale are returned as Taras, is this really true? I would have expected that we round or error. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@934 PS10, Line 934: Because DECIMAL type has a fixed size, the maximum and average size the DECIMAL type -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@539 PS10, Line 539: OUBLE > DOUBLE and FLOAT Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 27 Apr 2018 22:14:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@539 PS10, Line 539: OUBLE DOUBLE and FLOAT http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@540 PS10, Line 540: error returns. Maybe add the following. The reasoning is that the range of the floating point types is much wider than the range of the DECIMAL, so not every FLOAT or DOUBLE can be converted to a DECIMAL. However, every DECIMAL can be converted to a double or float with a loss of precision, which is why we allow implicit casting in this case. This is somewhat dangerous, but we made this design choice to match the behavior of other SQL engines. http://gerrit.cloudera.org:8080/#/c/10066/10/docs/topics/impala_decimal.xml@545 PS10, Line 545: Add this: We do not allow this because calculations involving decimals are meant to be precise, so we are strict and require explicit casts. However, if an approximate type like FLOAT is involved, then our behavior is less strict. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 27 Apr 2018 21:59:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#10). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 851 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/10 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 10 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@526 PS9, Line 526: 38,0 > We should be consistent about putting a space after the comma. Either put i Done http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@654 PS9, Line 654: is the INT : type with the precision 10. > ... because all digits do not fit into DECIMAL(3,0) Done http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@681 PS9, Line 681: > There should be no space before the open brace. Here and elsewhere. Done -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 9 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 27 Apr 2018 20:07:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml File docs/topics/impala_decimal.xml: http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@526 PS9, Line 526: 38,0 We should be consistent about putting a space after the comma. Either put it everywhere in the DOC or don't put it everywhere. http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@654 PS9, Line 654: is the INT : type with the precision 10. ... because all digits do not fit into DECIMAL(3,0) http://gerrit.cloudera.org:8080/#/c/10066/9/docs/topics/impala_decimal.xml@681 PS9, Line 681: There should be no space before the open brace. Here and elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 9 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 27 Apr 2018 19:21:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#9). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 850 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/9 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 9 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#8). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 845 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/8 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 8 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#7). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 854 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/7 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 7 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 6: I will email Taras the HTML version of the latest for review. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 6 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 27 Apr 2018 02:32:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#6). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 854 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/6 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 6 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 5: Let me know if you want me to distribute the latest draft in HTML to review. -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Mon, 16 Apr 2018 18:41:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/238/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 14 Apr 2018 17:04:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Sat, 14 Apr 2018 17:10:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#5). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 809 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/5 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#4). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 799 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/4 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/235/ -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 13 Apr 2018 23:19:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Hello Greg Rahn, Taras Bobrovytsky, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10066 to look at the new patch set (#3). Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 799 insertions(+), 708 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/3 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 2 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 13 Apr 2018 22:24:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10066 ) Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 The entire DECIMAL doc was refactored. Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/impala_keydefs.ditamap M docs/topics/impala_decimal.xml 2 files changed, 792 insertions(+), 675 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/2 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni
[Impala-ASF-CR] IMPALA-6522: [DOCS] Document Decimal V2
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10066 Change subject: IMPALA-6522: [DOCS] Document Decimal V2 .. IMPALA-6522: [DOCS] Document Decimal V2 The entire DECIMAL doc was refactored. Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Cherry-picks: not for 2.x. --- M docs/topics/impala_decimal.xml 1 file changed, 791 insertions(+), 674 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/10066/1 -- To view, visit http://gerrit.cloudera.org:8080/10066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic436ff80c9ad05cfada97280cd47552879214a3d Gerrit-Change-Number: 10066 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni