[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. Patch Set 3: Verified+1 This script isn't exercised by the precommit jobs and the RAT Check, etc passed. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Feb 2019 21:03:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. IMPALA-8186: script to configure docker network This automates the network setup that I did manually in http://gerrit.cloudera.org:8080/12189 After running the script it should be possible to run "./buildall.sh -format -testdata" to load test data with the right hostnames, then "start-impala-cluster.py --docker_network=network-name" to run a dockerised minicluster. Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Reviewed-on: http://gerrit.cloudera.org:8080/12452 Reviewed-by: Philip Zeyliger Tested-by: Tim Armstrong --- A docker/configure_test_network.sh 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Philip Zeyliger: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh
File docker/configure_test_network.sh:
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50
PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >>
bin/impala-config-local.sh
> There's some sort of "--bip" flag that I've used to make Docker not knock m
Locally I've passed in --gateway and --subnet to "docker network create" to
force it to use particular IPs. I'm going to think if just exposing those flags
is the right way to approach this or if there's a nicer way to handle it.
--
To view, visit http://gerrit.cloudera.org:8080/12452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d
Gerrit-Change-Number: 12452
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 12 Feb 2019 21:02:35 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2088/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Feb 2019 20:36:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG@15 PS2, Line 15: "start-impala-cluster.py --docker_network=network-name" > Should the network name end up in the env variables too? I think maybe eventually we'd want to be able to toggle docker mode via impala-config.sh; there isn't a good place to put it right now. Currently you have to put it in TEST_START_CLUSTER_ARGS and similar. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Feb 2019 20:10:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Hello Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12452 to look at the new patch set (#3). Change subject: IMPALA-8186: script to configure docker network .. IMPALA-8186: script to configure docker network This automates the network setup that I did manually in http://gerrit.cloudera.org:8080/12189 After running the script it should be possible to run "./buildall.sh -format -testdata" to load test data with the right hostnames, then "start-impala-cluster.py --docker_network=network-name" to run a dockerised minicluster. Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d --- A docker/configure_test_network.sh 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12452/3 -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network
..
Patch Set 2:
(4 comments)
No objections here; just thinking out loud about how some of this stuff works.
Fine by me to make incremental progress.
http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG@15
PS2, Line 15: "start-impala-cluster.py --docker_network=network-name"
Should the network name end up in the env variables too?
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh
File docker/configure_test_network.sh:
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@23
PS2, Line 23: # cluster configurations need to be regenerated, all minicluster
processes restarted,
nit, extra space.
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@45
PS2, Line 45: GATEWAY=$(docker network inspect "$NETWORK_NAME" | grep -o
'"Gateway": "[0-9\.]*"' | \
: grep -o "[0-9.]*")
I don't know if the following makes you any happier:
$docker network inspect bridge -f '{{(index .IPAM.Config 0).Gateway}}'
10.250.0.1
http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50
PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >>
bin/impala-config-local.sh
This clearly persists across restarts. Does the "docker network create" command
persist across reboots? Is Docker deterministic about the gateway?
--
To view, visit http://gerrit.cloudera.org:8080/12452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d
Gerrit-Change-Number: 12452
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:02:19 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 ) Change subject: IMPALA-8186: script to configure docker network .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2077/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Feb 2019 01:21:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12452/1/docker/configure_test_network.sh
File docker/configure_test_network.sh:
http://gerrit.cloudera.org:8080/#/c/12452/1/docker/configure_test_network.sh@51
PS1, Line 51: echo "export DEFAULT_FS=hdfs://\${INTERNAL_LISTEN_HOST}:20500" >>
bin/impala-config-local.sh
> line too long (92 > 90)
Done
--
To view, visit http://gerrit.cloudera.org:8080/12452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d
Gerrit-Change-Number: 12452
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Tue, 12 Feb 2019 00:46:52 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12452 to look at the new patch set (#2). Change subject: IMPALA-8186: script to configure docker network .. IMPALA-8186: script to configure docker network This automates the network setup that I did manually in http://gerrit.cloudera.org:8080/12189 After running the script it should be possible to run "./buildall.sh -format -testdata" to load test data with the right hostnames, then "start-impala-cluster.py --docker_network=network-name" to run a dockerised minicluster. Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d --- A docker/configure_test_network.sh 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12452/2 -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12452/1/docker/configure_test_network.sh
File docker/configure_test_network.sh:
http://gerrit.cloudera.org:8080/#/c/12452/1/docker/configure_test_network.sh@51
PS1, Line 51: echo "export DEFAULT_FS=hdfs://\${INTERNAL_LISTEN_HOST}:20500" >>
bin/impala-config-local.sh
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d
Gerrit-Change-Number: 12452
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Tue, 12 Feb 2019 00:37:50 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8186: script to configure docker network
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12452 Change subject: IMPALA-8186: script to configure docker network .. IMPALA-8186: script to configure docker network This automates the network setup that I did manually in http://gerrit.cloudera.org:8080/12189 After running the script it should be possible to run "./buildall.sh -format -testdata" to load test data with the right hostnames, then "start-impala-cluster.py --docker_network=network-name" to run a dockerised minicluster. Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d --- A docker/configure_test_network.sh 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/12452/1 -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
