Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network ...................................................................... Patch Set 2: (4 comments) No objections here; just thinking out loud about how some of this stuff works. Fine by me to make incremental progress. http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG@15 PS2, Line 15: "start-impala-cluster.py --docker_network=network-name" Should the network name end up in the env variables too? http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh File docker/configure_test_network.sh: http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@23 PS2, Line 23: # cluster configurations need to be regenerated, all minicluster processes restarted, nit, extra space. http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@45 PS2, Line 45: GATEWAY=$(docker network inspect "$NETWORK_NAME" | grep -o '"Gateway": "[0-9\.]*"' | \ : grep -o "[0-9.]*") I don't know if the following makes you any happier: $docker network inspect bridge -f '{{(index .IPAM.Config 0).Gateway}}' 10.250.0.1 http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50 PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >> bin/impala-config-local.sh This clearly persists across restarts. Does the "docker network create" command persist across reboots? Is Docker deterministic about the gateway? -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 19:02:19 +0000 Gerrit-HasComments: Yes
