Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12452/2//COMMIT_MSG@15 PS2, Line 15: "start-impala-cluster.py --docker_network=network-name" > Should the network name end up in the env variables too? I think maybe eventually we'd want to be able to toggle docker mode via impala-config.sh; there isn't a good place to put it right now. Currently you have to put it in TEST_START_CLUSTER_ARGS and similar. -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 20:10:34 +0000 Gerrit-HasComments: Yes
