[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4877 to look at the new patch set (#3). Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-11-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 11: Code-Review+1 Forgot to carry Tim's +1 from 23 October -- To view, visit

[Impala-ASF-CR] IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality().

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4925 Change subject: IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality(). .. IMPALA-4174: Refine PK/FK detection in

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4815 To

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 6: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-02 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. IMPALA-4421: Send custom cluster & process failure test results to logs/ Improperly

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-02 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4918/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4421: Send custom cluster & process failure test results to logs/

2016-11-02 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-4421: Send custom cluster & process failure test results to logs/ .. IMPALA-4421: Send custom cluster & process failure test results to logs/ Improperly

[Impala-ASF-CR] IMPALA-4384: NPE when cols list has trailing comma

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4384: NPE when cols list has trailing comma .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 5: (5 comments) Looks reasonable, thanks!

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-4423: Correct but conservative implementation of Subquery.equals().

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4923 Change subject: IMPALA-4423: Correct but conservative implementation of Subquery.equals(). .. IMPALA-4423: Correct but conservative

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-11-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 2: (16 comments)

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (19 comments)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4873

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Revert "IMPALA-4314: Standardize on MT-related data structures"

2016-11-02 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: Revert "IMPALA-4314: Standardize on MT-related data structures" .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4903 To unsubscribe, visit

Re: [Impala-ASF-CR] Revert "IMPALA-4314: Standardize on MT-related data structures"

2016-11-02 Thread Alex Behm
Abandon? On Tue, Nov 1, 2016 at 1:35 PM, Marcel Kornacker (Code Review) < ger...@cloudera.org> wrote: > Marcel Kornacker has posted comments on this change. > > Change subject: Revert "IMPALA-4314: Standardize on MT-related data > structures" >

[Impala-ASF-CR] IMPALA-4258: Remove duplicated and unused test macros

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4258: Remove duplicated and unused test macros .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or .. IMPALA-4381: Incorrect AVX version of BloomFilter::Or The iteration on the loop

[Impala-ASF-CR] IMPALA-4381: Incorrect AVX version of BloomFilter::Or

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4866 To unsubscribe,

[Impala-ASF-CR] IMPALA-4330: Fix JSON syntax in generate metrics.py

2016-11-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4330: Fix JSON syntax in generate_metrics.py .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4887 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 4: Patch set 4 adds Table object properties for the names of the columns

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#4). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. IMPALA-4352: test infra: store Impala/Kudu primary keys in object model Test

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. Patch Set 1: Code-Review+2 as discussed, please do the unittest as a

[Impala-ASF-CR] IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir

2016-11-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir

2016-11-02 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/4918 Change subject: IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir .. IMPALA-4421: Write custom

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 3: (4 comments) Thanks Matthew. Please see patch set 3.

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. IMPALA-4352: test infra: store Impala/Kudu primary keys in object model Test

[Impala-ASF-CR] IMPALA-4258: Remove duplicated and unused test macros

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4258: Remove duplicated and unused test macros .. Patch Set 1: Code-Review+2 Nice! Looks like we already got rid of some instances of it. -- To view,

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Sorry about that, should've known you were on vacation! -- To view, visit

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4835 To

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-11-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test

2016-11-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test .. Patch Set 2: Private build passed here:

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-02 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-11-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4755 To

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 2: (1 comment) Thanks for the comment, Taras. Please set patch set 2.

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-11-02 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. IMPALA-4352: test infra: store Impala/Kudu primary keys in object model Test

[Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0

2016-11-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4913 Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0 .. IMPALA-4412: Per operator timing in