[Impala-ASF-CR] IMPALA-4000: Disable Sentry column-level privileges for Kudu

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu .. Patch Set 1: I don't think disabling column-level privileges is the desired behavior.

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof This was

[Impala-ASF-CR] IMPALA-4452: Always call AggFnEvaluator::Open() before AggFnEvaluator::Init()

2016-11-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5049 Change subject: IMPALA-4452: Always call AggFnEvaluator::Open() before AggFnEvaluator::Init() .. IMPALA-4452: Always call

[Impala-ASF-CR] IMPALA-4000: Disable Sentry column-level privileges for Kudu

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5047 Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu .. IMPALA-4000: Disable Sentry column-level privileges

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3812: Fix error message for unsupported types .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-3812: Fix error message for unsupported types

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3812: Fix error message for unsupported types .. IMPALA-3812: Fix error message for unsupported types Before this patch an unclear error message was

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Patch Set 4: (9 comments) Here's how I think about the lock safety (sorry, long, but hopefully helps to

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5022 To

[Impala-ASF-CR] IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr()

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr()

2016-11-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr() .. IMPALA-4465: Don't hold process wide lock while

[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.

2016-11-10 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. IMPALA-4461: Make sure data gets loaded for wide hbase tables. Ths patch reverts a

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py File

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/4/tests/query_test/test_scanners.py File

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/4/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] Preview: IMPALA-4363: Add timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Preview: IMPALA-4363: Add timestamp validation .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#8). Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ..

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#7). Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ..

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py File

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5040 Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. IMPALA-4454: test_kudu.TestShowCreateTable flaky The cause

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. Patch Set 3: Once concern I have is about fairness. It's pretty critical that writers

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4867 to look at the new patch set (#11). Change subject: IMPALA-3552: Make incremental stats max serialized size configurable

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (5 comments)

[Impala-ASF-CR] Preview: IMPALA-4363: Add timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: Preview: IMPALA-4363: Add timestamp validation .. Preview: IMPALA-4363: Add timestamp validation Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf --- M

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-4456: Change query exec state lock to a reader-writer lock

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer lock .. Patch Set 3: (4 comments) Did you consider boost::scoped_mutex?

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof .. Patch Set 3: Data load failed with #7 0x01853932 in

[Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

2016-11-10 Thread Jim Apple (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5022 to look at the new patch set (#3). Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPDATE test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5036 Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage .. IMPALA-4466: Improve Kudu UPDATE test coverage Change-Id:

[Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr()

2016-11-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-10 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5034 Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. IMPALA-4450: qgen: use string

[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.

2016-11-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5033 To unsubscribe,

[Impala-ASF-CR] IMPALA-4461: Make sure data gets loaded for wide hbase tables.

2016-11-10 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5033 Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables. .. IMPALA-4461: Make sure data gets loaded for wide hbase

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#5). Change subject: Improve Kudu UPSERT test coverage .. Improve Kudu UPSERT test

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4953/4//COMMIT_MSG Commit Message: PS4, Line 9:

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. Patch Set 6: (4 comments) There are still some minor formatting issues left.