[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: Lars, technically I can't +2 your patch. Ping Alex, it should be trivial to review. -- To view,

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6923 To unsubscribe,

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5340: Query profile displays stale query state .. IMPALA-5340: Query profile displays stale query state Previously, updates to the query

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 7: Added some toSql tests. -- To view, visit http://gerrit.cloudera.org:8080/6878 To

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add REFRESH FUNCTIONS statement Before this patch, Impala relied on INVALIDATE METADATA to load

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6878 to look at the new patch set (#7). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add

[Impala-ASF-CR] IMPALA-5338: Fix Kudu timestamp column default values

2017-05-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6936 Change subject: IMPALA-5338: Fix Kudu timestamp column default values .. IMPALA-5338: Fix Kudu timestamp column default values While

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-19 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6935/1/be/src/benchmarks/free-lists-benchmark.cc File

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-05-19 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6935 Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 3: > I have a few high level questions about this patch. This patch > treats S3 and ADL the

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6921 To

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add REFRESH FUNCTIONS statement Before this patch, Impala relied on INVALIDATE METADATA to load

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 6: Updated the toSql statement in the latest patch -- To view, visit

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6878 to look at the new patch set (#6). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix client request state map lock contention

2017-05-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention .. IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention Holding

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix client request state map lock contention

2017-05-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention .. IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention Holding

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix client request state map lock contention

2017-05-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention .. Patch Set 7: (8 comments) The new test fails deterministically without the

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/597/ -- To

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 6: Code-Review+1 LGTM. I think it'd be good to get MikeB or David to sign off on the

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: > I should also add - I haven't tested this with CM, just locally > with the debug webpage,

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#10). Change subject: IMPALA-4623: Enable file handle cache .. IMPALA-4623: Enable file handle cache Currently, every scan range maintains a file handle, even when multiple scan

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: Code-Review+2 I should also add - I haven't tested this with CM, just locally

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 5: Code-Review+1 Forwarding the +1 from Alex. -- To view, visit

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add REFRESH FUNCTIONS statement Before this patch, Impala relied on INVALIDATE METADATA to load

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6878 to look at the new patch set (#5). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6923/3/tests/query_test/test_observability.py

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6923 to look at the new patch set (#3). Change subject: IMPALA-5340: Query profile displays stale query state

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6933 Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix client request state map lock contention

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 4: Code-Review+1 (1 comment) Dimitris should sign off on the catalog changes.

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#9). Change subject: IMPALA-4623: Enable file handle cache .. IMPALA-4623: Enable file handle cache Currently, every scan range maintains a file handle, even when multiple scan ranges

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 8: (15 comments) http://gerrit.cloudera.org:8080/#/c/6478/8/be/src/runtime/disk-io-mgr-handle-cache.h File

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 2: Code-Review+2 > (1 comment) > > > Any good way to regression test this? > > Obviously

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add REFRESH FUNCTIONS statement Before this patch, Impala relied on INVALIDATE METADATA to load

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 2: (1 comment) > Any good way to regression test this? Obviously its a timing

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/596/

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 4: Code-Review+2 Rebased, carrying Dimitris' +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. IMPALA-5259: Add REFRESH FUNCTIONS statement Before this patch, Impala relied on INVALIDATE METADATA to load

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. IMPALA-3973: optional 3rd and 4th arguments for instr(). Change-Id:

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5589 To

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/114/ --

[Impala-ASF-CR] Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet"

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet" .. Patch Set 1: Code-Review+2 (3 comments) I only looked at the files with

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 3: I have a few high level questions about this patch. This patch treats S3 and ADL

[Impala-ASF-CR] IMPALA-5340: Query profile displays stale query state

2017-05-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state .. Patch Set 2: Any good way to regression test this? -- To view, visit http://gerrit.cloudera.org:8080/6923

[Impala-ASF-CR] IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"

2017-05-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" .. Patch Set 6: > Unfortunately, Python 2.6 doesn't have check_output(). So I've used > Popen()

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6921 To

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-05-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 4: (1 comment) Thanks for the changes. The code changes look good aside from one minor comment. After

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Lars Volker (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6921 to look at the new patch set (#3). Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 2: (14 comments) Thanks for the comments on the patchset, Tim! I've worked on the points you

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-05-19 Thread Valencia Edna Serrao (Code Review)
Valencia Edna Serrao has uploaded a new patch set (#4). Change subject: Ported native-toolchain to work on ppc64le .. Ported native-toolchain to work on ppc64le Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a --- M

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6575

[Impala-ASF-CR] IMPALA-5180: Don't use non-deterministic exprs in partition pruning

2017-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5180: Don't use non-deterministic exprs in partition pruning .. IMPALA-5180: Don't use non-deterministic exprs in partition pruning