[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls .. IMPALA-5455: test infra: default --cm-port based on --use-tls This patch sets

[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7107 To

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/702/

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 11: Code-Review+2 Fix the static_assert(). Verified it builds with clang now. Carry +2

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Hello Impala Public Jenkins, Juan Yu, Henry Robinson, Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7063 to look at the new patch set (#11). Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#8). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7038 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5400: Execute tests in subplans.test .. IMPALA-5400: Execute tests in subplans.test This change executes the tests added to

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 2: (23 comments) Code comments. Still going through the tests.

[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/701/

[Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls

2017-06-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls .. Patch Set 2: Code-Review+2 nice, thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/700/

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 1: (21 comments) Thanks for taking on this issue! Comments should give you some

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 10: Code-Review+2 Thanks for all the reviews. Carry +2 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/7063/9/be/src/rpc/thrift-util.cc

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Hello Juan Yu, Henry Robinson, Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7063 to look at the new patch set (#10). Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR .. IMPALA-4164: Avoid overly aggressive inlining in LLVM IR When generating IR

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (2 comments) I am just answering two questions that Dan had. Let me

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 9: Code-Review+2 +2 after addressing Henry's comments. -- To view, visit

[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values

2017-06-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. Patch Set 2: (10 comments) There's a few instances of extra whitespace. There should be an editor

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-07 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7110 Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 9: Code-Review+1 (6 comments) Thanks - I think this is a great improvement.

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 6: Code-Review+2 Rebase -- To view, visit

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7045 To

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Code-Review+1 (1 comment) Hope there are no occurrences of this construct in

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h File

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Henry Robinson (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7045 to look at the new patch set (#5). Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls

2017-06-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls

2017-06-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7107 To unsubscribe,

[Impala-ASF-CR] IMPALA-5455: test infra: propagate --cm-port, add --use-tls

2017-06-07 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/7107 Change subject: IMPALA-5455: test infra: propagate --cm-port, add --use-tls .. IMPALA-5455: test infra: propagate --cm-port, add

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7106 Change subject: IMPALA-5454: Work around template rendering bug in /memz .. IMPALA-5454: Work around template rendering bug in /memz A

[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values

2017-06-07 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. IMPALA-3603 [DOCS] Document handling of NaN values Added information in the "DOUBLE Data Type"

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 2: (13 comments) The rewrite code looks very clean and concise!

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 4: Henry, you mentioned you'd post a new patch once my concerns are

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/698/ -- To view,

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7038 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/6812/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5036: Parquet count star optimization .. IMPALA-5036: Parquet count star optimization Instead of materializing empty rows when computing count star, we

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/697/ --

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR .. Patch Set 10: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/6941

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7064 To

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 5: Removing the test that failed. Raised a JIRA to track it -

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#7). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 6: (1 comment) Found a bug. Plz wait until I post a new patch before

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 6: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 9: Code-Review+1 LGTM as well. -- To view, visit http://gerrit.cloudera.org:8080/7063

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-07 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#11). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7103 Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This patch ports the

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-07 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5720 to look at the new patch set (#11). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

[Impala-ASF-CR] IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#7). Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8 .. IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8 Change-Id:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-06-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#7). Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 The security

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@314c9d8

2017-06-07 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5714 to look at the new patch set (#7). Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 9: Code-Review+1 LGTM but would be good to have Henry and Sailesh sign off they have no

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 9: Code-Review+1 Carry +1 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6941/8/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR .. Patch Set 9: The latest patch switches to using inlining threshold of InlineHint as it seems to result

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-07 Thread Michael Ho (Code Review)
Hello Juan Yu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7063 to look at the new patch set (#9). Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ..

[Impala-ASF-CR] IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

2017-06-07 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6941 to look at the new patch set (#9). Change subject: IMPALA-4164: Avoid overly aggressive inlining in LLVM IR

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-07 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 3: (2 comments) > Thanks a lot for change. It's ok for me. Thanks, Peter!

[Impala-ASF-CR] PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 18: Cleaned up the patch and split out https://gerrit.cloudera.org/#/c/7102/ -- To

[Impala-ASF-CR] PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#18). Change subject: PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool .. PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7102 Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674: Part 1: remove old aggs and joins This is intended to be

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. IMPALA-5085: large rows in BufferedTupleStreamV2 The stream defaults to pages of default_page_len_. If a row

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5164: Fix flaky benchmarks .. IMPALA-5164: Fix flaky benchmarks Improve benchmarks by detecting involuntary context switches. If a server is

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-06-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6935 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5400: Execute tests in subplans.test .. Patch Set 4: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/696/ -- To

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-07 Thread Peter Brejcak (Code Review)
Peter Brejcak has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 3: Thanks a lot for change. It's ok for me. -- To view, visit

[Impala-ASF-CR] IMPALA-5164: Fix flaky benchmarks

2017-06-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5164: Fix flaky benchmarks .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6935 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When