[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. IMPALA-5030: [DOCS] Document nvl2() function Change-Id:

[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7365 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4431: [DOCS] Document max audit event log files startup option

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option .. IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option

[Impala-ASF-CR] IMPALA-4431: [DOCS] Document max audit event log files startup option

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/135/ -- To view,

[Impala-ASF-CR] IMPALA-4431: [DOCS] Document max audit event log files startup option

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/829/ -- To view,

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/828/ -- To

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-07-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/7175/2/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-06 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: This is a abnormal test case which terminated immediately. This is different

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 8: > I have tried to merge code, but IMPALA-5506 modified the same code. > I

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-06 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 8: I have tried to merge code, but IMPALA-5506 modified the same code. I

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-06 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#8). Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. IMPALA-5507: Add clear description to help information of KEYVAL option Help information

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-06 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#7). Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. IMPALA-5507: Add clear description to help information of KEYVAL option Help information

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7364 To unsubscribe,

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-06 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 3: (6 comments) Looks promising! http://gerrit.cloudera.org:8080/#/c/7267/3/be/src/exec/partial-sort-node.cc

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7358 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.cc File

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/828/ -- To view,

[Impala-ASF-CR] IMPALA-5623: Fix lag() on STRING cols to release UDF mem

2017-07-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7371 Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem .. IMPALA-5623: Fix lag() on STRING cols to release UDF mem

[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4431: [DOCS] Document max audit event log files startup option

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7369 To

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7358/3/be/src/runtime/buffered-tuple-stream-v2.h

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. IMPALA-5618: buffered-tuple-stream-v2 fixes This fixes two issues: * AddRowCustom() caused a performance regression

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7358/3/be/src/runtime/buffered-tuple-stream-v2.h File

[Impala-ASF-CR] IMPALA-4431: [DOCS] Document max audit event log files startup option

2017-07-06 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7369 Change subject: IMPALA-4431: [DOCS] Document max_audit_event_log_files startup option .. IMPALA-4431: [DOCS] Document

[Impala-ASF-CR] Complete guide to important environment variables for build, test, and mini-cluster operations.

2017-07-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#14). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-07-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. IMPALA-3504: UDF for current timestamp in UTC This change adds a UDF "utc_timestamp" which returns

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-07-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7203 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#23). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7203 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 13: (6 comments) The backend changes look good. I'll make another pass through

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7022 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#22). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-07-06 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7022 to look at the new patch set (#6). Change subject: IMPALA-4703: reservation denial debug action .. IMPALA-4703:

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. Patch Set 7: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7102 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7367 Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-07-06 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7102 to look at the new patch set (#7). Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674:

[Impala-ASF-CR] IMPALA-5618: buffered-tuple-stream-v2 fixes

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5618: buffered-tuple-stream-v2 fixes .. IMPALA-5618: buffered-tuple-stream-v2 fixes This fixes two issues: * AddRowCustom() caused a performance regression

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 1: (2 comments) The overall approach seems good, but I had some concerns about the

[Impala-ASF-CR] IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7346 To

[Impala-ASF-CR] IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily .. IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily IMPALA-3742

[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. Patch Set 1: I noticed that I hadn't set up the infrastructure yet to have 'added in release such-and-such'

[Impala-ASF-CR] IMPALA-5030: [DOCS] Document nvl2() function

2017-07-06 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7365 Change subject: IMPALA-5030: [DOCS] Document nvl2() function .. IMPALA-5030: [DOCS] Document nvl2() function Change-Id:

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/827/ -- To

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7364 to look at the new patch set (#2). Change subject: IMPALA-5580: fix Java UDFs that return NULL strings ..

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7364/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 1: (8 comments) Looks good overall. I had a few minor style comments then a bigger question about

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] add EPOCH to list of units supported. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7342 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] add EPOCH to list of units supported. .. [DOCS] add EPOCH to list of units supported. Per

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 1: Code-Review+1 (1 comment) Looks good to me. I'll leave it up to Bharath to +2 once he's

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] add EPOCH to list of units supported. .. Patch Set 2: Code-Review+2 I'll do the 'doc validation job' step and take it from here into the master branch.

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7364/1/be/src/exprs/hive-udf-call.cc File

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] add EPOCH to list of units supported. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/133/ -- To view,

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7364/1/be/src/exprs/hive-udf-call.cc

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread Greg Rahn (Code Review)
Greg Rahn has uploaded a new patch set (#2). Change subject: [DOCS] add EPOCH to list of units supported. .. [DOCS] add EPOCH to list of units supported. Per

[Impala-ASF-CR] IMPALA-5580: fix Java UDFs that return NULL strings

2017-07-06 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/7364 Change subject: IMPALA-5580: fix Java UDFs that return NULL strings .. IMPALA-5580: fix Java UDFs that return NULL strings In commit

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] add EPOCH to list of units supported. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7342/1/docs/topics/impala_datetime_functions.xml

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 12: (21 comments)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-07-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-07-06 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. IMPALA-5583: [DOCS] Document default_join_distribution_mode query option New page for

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7267/2/common/thrift/PlanNodes.thrift File

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-5498: Support for partial sorts .. IMPALA-5498: Support for partial sorts Impala currently supports total sorts (the entire set of data is sorted)

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLS=1

2017-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 .. Patch Set 3: (2 comments) Looks good to me. If you fix the typo in the commit message

[Impala-ASF-CR] IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily

2017-07-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily .. Patch Set 5: Code-Review+1 LGTM. -- To view, visit http://gerrit.cloudera.org:8080/7346 To

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-07-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/826/ -- To view,

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#9). Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. IMPALA-5240: Allow config of number of disk I/O threads per disk type Currently Impala

[Impala-ASF-CR] IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily

2017-07-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-07-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 1: (2 comments) Not a full review. I had some questions on the JIRA.

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Code-Review+1 (1 comment) LGTM.

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 6: OK, looks good. If you rebase on the latest HEAD, I can push the change.

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-06 Thread Anonymous Coward (Code Review)
gaborkas...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7363 Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web