[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 29: (24 comments) http://gerrit.cloudera.org:8080/#/c/5801/29/be/src/exec/partitioned-aggregat

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#30). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 20: PS20 got further than before (i.e. impalad binaries can start up with --build_shared_

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-12 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#21). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...

[Impala-ASF-CR] IMPALA-5539: Kudu timestamp scans wrong with -use local tz for unix ts

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts .. Patch Set 2: (2 comments) This looks fine to me once you add the tests. Let's still do th

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 29: (26 comments) http://gerrit.cloudera.org:8080/#/c/5801/29/be/src/exec/partitioned-aggregation-

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/3/be/src/exec/partitioned-aggregation-node.cc

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 3: It turns out that a change in PAGG node was required as Michael suggested. Can you take a loo

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPALA-5036) introdu

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7404 to look at the new patch set (#3). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMP

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7267/4/be/src/runtime/sorter.h File be/src/runtime/sorter

[Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers

2017-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5627: fix dropped statuses in HDFS writers .. Patch Set 4: (4 comments) Thank you for fixing this! Please see my inline comments. http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-12 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#20). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Hello Lars Volker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7404 to look at the new patch set (#2). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMP

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet count(*) optimization (IMPALA-5036) introdu

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 20: New patch has a possible fix for the dual-linking of glog problem. Running a test on

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 2: (1 comment) I think we need to figure out a way to test this. A test could be added to test

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 2: (1 comment) The JIRA shows an example & log snippet where only one of the two grants on dat

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 28: (10 comments) http://gerrit.cloudera.org:8080/#/c/5801/26/be/src/runtime/query-state.cc Fi

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#29). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: Code-Review+2 Please make sure you do some proper testing with the PAGG too as this actually affects

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/5801/26/be/src/runtime/query-state.cc File be/

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 28: (12 comments) LMK if i missed responding to anything. http://gerrit.cloudera.org:8080/#/c/580

[Impala-ASF-CR](asf-site) Clean up ASF docs page

2017-07-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Clean up ASF docs page .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7407 To unsubscribe, visit http://gerrit.cloudera.org:8080/setti

[Impala-ASF-CR](asf-site) Clean up ASF docs page

2017-07-12 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Clean up ASF docs page .. Clean up ASF docs page 1. Make book links look less like advertisements or endorsements 2. Organize Older Releases by version 3. R

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#4). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#5). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad, catalogd

[Impala-ASF-CR](asf-site) Clean up ASF docs page

2017-07-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Clean up ASF docs page .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7407 To unsubscribe, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR](asf-site) Remove link to old docs for non-ASF versions of Impala

2017-07-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7407 Change subject: Remove link to old docs for non-ASF versions of Impala .. Remove link to old docs for non-ASF versions of Impala Change-Id:

[Impala-ASF-CR](asf-site) Clean up ASF docs page

2017-07-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Clean up ASF docs page .. Clean up ASF docs page 1. Make book links look less like advertisements or endorsements 2. Organize Older Releases by version 3. Remove link

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-12 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-12 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 3: Code-Review+2 The comments on that opening impa

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-12 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Add Impala 2.9 docs from master branch, with commit