[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1191

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 7: Code-Review+2 Rebase, carry +2. -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. [security] avoid kerberos ticket renewal and only reacquire It was found that if

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7898 To unsubsc

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: Code-Review+2 Carry +2 w/rebase. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1190/ --

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7938/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork Impala currently kinits by forking off a c

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7949 Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. IMPALA-5597: Check predicate children typ

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7948 Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. IMPALA-4620: Refactor evalcost computation in query analysi

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 2: (2 comments) Added some test cases testing 1400/ edge cases. http://gerrit.cloudera.org:8080/#/c/7

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix bugs parsing 2-digit year This patch fixes several bugs parsing 1 or 2-digit year formats. Existing co

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 9: Code-Review+1 LGTM after checking whether not calling StartServices() (and therefore not

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/catalog/catalog-server.h

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#9). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMP

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7943/1/be/src/runtime/coordin

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 3: Any more comments Lars? -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 6: I just want to add the reason for back-porting this: This patch fixes KRPC to

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 6: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1189/ --

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 5: Code-Review+2 (1 comment) Rebase, carry +2. http://gerrit.cloudera.org:8080/#/c/789

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG Com

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7943/1/be/src/runtime/coor

[Impala-ASF-CR] IMPALA-5628: (Draft) Add support for reading additional Parquet Decimal Types

2017-09-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-5628: (Draft) Add support for reading additional Parquet Decimal Types .. IMPALA-5628: (Draft) Add support for reading additional Parquet Decimal Types Ad

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 1: (2 comments) Thanks for the explanations. I think I follow the code now. Just had a couple of minor

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-09-01 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7945 Change subject: Tighten up advice about first COMPUTE INCREMENTAL STATS .. Tighten up advice about first COMPUTE INCREMENTAL STATS Explai

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7943 Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. IMPALA-5892: Allow reporting status independent

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 2: (8 comments) Some quick comments. http://gerrit.cloudera.org:8080/#/c/7938/2//COMMIT_MS

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 1: (6 comments) Refactored and changed a few logic to make it a little bit closer to Hive. http://gerrit.

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix bugs parsing 2-digit year This patch fixes several bugs parsing 1 or 2-digit year formats. Existing co

[Impala-ASF-CR] IMPALA-5871: KuduPartitionExpr incorrectly handles its child types

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7922 To

[Impala-ASF-CR] IMPALA-5871: KuduPartitionExpr incorrectly handles its child types

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types .. IMPALA-5871: KuduPartitionExpr incorrectly handles its child types KuduPa

[Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: [security] avoid kerberos ticket renewal and only reacquire .. Patch Set 4: Code-Review+2 (1 comment) I didn't look too deeply into the change given it's a mostly

[Impala-ASF-CR] IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 4: Need to rebase again after https://gerrit.cloudera.org/#/c/7897/5 is merged. That patch changes the c'tor inte

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7897 To unsubscr

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork Impala currently kinits by forking off a s

[Impala-ASF-CR] IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7938 Change subject: IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork .. IMPALA-4129: Use KRPC's Kinit code to avoid expensive fork

[Impala-ASF-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-09-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7897 To unsub

[Impala-ASF-CR] IMPALA-5881: Use TCompactProtocol for getAllCatalogObjects() call

2017-09-01 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. Change subject: IMPALA-5881: Use TCompactProtocol for getAllCatalogObjects() call .. Abandoned Discussed with Alex, we decided to redo the way getAllCatalogObjects() does memory

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (2 comments) I need to go through query-state one more time, but otherwise here's my remai

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-4670: Introduces RpcMgr class .. IMPALA-4670: Introduces RpcMgr class This patch introduces a new class, RpcMgr which is the abstraction layer around KRPC core

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/7901/3/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-te

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/7730/8/be/src/catalog/catalog-server.h

[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.

2017-09-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new change for review. http://gerrit.cloudera.org:8080/7937 Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior. .. IMPALA-1641: adds an end-to-end test to capture cur

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/7/be/src/exec/kudu-scan-node.cc Fi

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-4670: Introduces RpcMgr class .. IMPALA-4670: Introduces RpcMgr class This patch introduces a new class, RpcMgr which is the abstraction layer around KRPC core

[Impala-ASF-CR] IMPALA-5871: KuduPartitionExpr incorrectly handles its child types

2017-09-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/118

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7730/7/be/src/exec/kudu-scan-node.cc F

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-01 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#8). Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMP

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5888: free other local allocations in Parquet .. IMPALA-5888: free other local allocations in Parquet Testing: I wasn't able to produce any abnormal memory

[Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet

2017-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5885: free runtime filter allocations in Parquet .. IMPALA-5885: free runtime filter allocations in Parquet This fixes the parquet scanner to free local all

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-01 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > (1 comment) The tests in this change use only 3 query options. Adding a ne