Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Remove compile-time checks for OpenSSL > 1.0.0 ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7866/3//COMMIT_MSG Commit Message: Line 51: Error messages > Thanks for finding and fixing this up. Would it make sense to not startup i That's a good suggestion, but having thought about it I think I'd prefer not to. The reason: this would wind up looking something like ABORT_IF_ERROR(CheckSslConfiguration()); in each daemon's init method. I'm a bit cautious about this because we might forget (and we have a track record of forgetting to do this kind of thing in every daemon!), or if someone someday writes a new daemon or test, they might forget to do so. So that makes an argument for retaining the protocol checking logic inside Thrift[Server|Client], and in that case I'd prefer to put the logic in just one place. The cluster should fail to start in either case. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/7866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20c5d39c0c4ae9c5445dd3ee3b175fe337a5728d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
