[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: There is still one thing that is not clear to me. Why is it allowed to do an ALTER TABLE with an

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: (7 comments) http://gerrit.cloudera.org:8080/#/c/6495/17//COMMIT_MSG Commit Message: PS17, Line

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: I think the interaction between the hint and clause confused me at some point. I'll take another

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: Quick question. Is there a reason why we don't remove the sortby hint in this patch? -- To view,

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 7: Code-Review+2 Rebase and minor test fix. Keep Dan's +2 -- To view,

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6628 to look at the new patch set (#7). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution

[Impala-ASF-CR] IMPALA-5152: Gather all tables with missing metadata in analysis

2017-04-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5152: Gather all tables with missing metadata in analysis .. Patch Set 1: As we discussed offline, see if it makes sense to have a quick

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 3: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: (19 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (15 comments)

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 2: (5 comments) Some comments/questions. No new patch until we answer these first.

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6628 Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6603 Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (6 comments) Quick pass with some minor comments. I am still trying to wrap my

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 9: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 7: (18 comments) http://gerrit.cloudera.org:8080/#/c/6495/7/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 5: (5 comments) Responses to some comments.

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 5: (20 comments) http://gerrit.cloudera.org:8080/#/c/6495/5/common/thrift/JniCatalog.thrift File

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6495/3//COMMIT_MSG Commit Message: PS3, Line 13:

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 3: (1 comment) Lars, a few high level questions before I start the next review iteration. Thanks

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 2: (20 comments) Initial pass, haven't looked at the tests yet.

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 6: Code-Review+2 Keep Henry's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6344 to look at the new patch set (#6). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 5: (6 comments) Thanks Henry!

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for storing file metadata This commit

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 4: (10 comments) I am not so sure about removing the catalog and

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 3: (12 comments)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6408 To unsubscribe,

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for storing file metadata This commit

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/6406/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 1: Code-Review+2 In terms of testing, you may run a private jenkins jobs to test your

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6406 Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements

[Impala-ASF-CR] Fix typo in Flatbuffers cmake module

2017-03-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix typo in Flatbuffers cmake module .. Patch Set 1: Code-Review+2 Thanks Henry -- To view, visit http://gerrit.cloudera.org:8080/6398 To unsubscribe,

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-03-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6344 Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6296 To

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 4: Code-Review+2 Rebase and keep Henry's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6013 to look at the new patch set (#4). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: Any more comments on this? Henry, lmk if you're swamped and I will ask someone else to

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4966: Add flatbuffers to build .. Patch Set 2: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://gerrit.cloudera.org:8080/6180 To

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/6013/2/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6180 Change subject: IMPALA-4966: Add flatbuffers to build .. IMPALA-4966: Add flatbuffers to build FlatBuffers version 1.6.0 is

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6127 To

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (10 comments) Thanks for the suggestions Henry. New screenshots are here:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the

[Impala-ASF-CR] IMPALA-4840: Fix REFRESH performance regression.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4840: Fix REFRESH performance regression. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6009 To unsubscribe,

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: A publicly available screenshot:

[Impala-ASF-CR] IMPALA-4916: Fix maintenance of set of item sets in DisjointSet.

2017-02-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4916: Fix maintenance of set of item sets in DisjointSet. .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: A screenshot of the new web page with the JVM thread info is here:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6013 Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4897: AnalysisException: specified cache pool does not exist

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4897: AnalysisException: specified cache pool does not exist .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Fix merge conflict

2017-02-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix merge conflict .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5967 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+2 Here is a screenshot from my dev box for the catalog/memz

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 2: Code-Review+1 Keep Alex's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5909 to look at the new patch set (#2). Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI ..

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5909 Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. IMPALA-4884: Add JVM heap and non-heap usage

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Yes, looking at it now. -- To view, visit

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has abandoned this change. Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. Abandoned MJ posted a fix for this. -- To view, visit http://gerrit.cloudera.org:8080/5507 To unsubscribe,

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables This

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-02-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. Patch Set 1: (6 comments)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: John, when do you plan to post a new patch that addresses the last comments? I think after

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 13: Code-Review+1 (5 comments) I'll let MJ and/or Todd make a final pass.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5743

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 4: (1 comment)

<    1   2   3   4   5   >