Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 16:
(1 comment)
After fighting the compiler for over an hour to figure out why our operator<<
was not be
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/16//COMMIT_MSG
Commit Message:
Line 64: Qu
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 10:
(1 comment)
I am trying to get the DCHECK_EQ to work with int128_t, for which we do provide
a defini
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h
File be/
Zach Amsden has uploaded a new patch set (#16).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 12:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG
Commit Message:
Line 122
> Sure
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h
File be/s
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG
Commit Message:
Line 122: do to ge
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 15:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5951/15/be/src/benchmarks/expr-benchmark.cc
File be/s
Zach Amsden has uploaded a new patch set (#15).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Zach Amsden has uploaded a new patch set (#13).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h
File b
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 12:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5951/12//COMMIT_MSG
Commit Message:
PS12, Line 15: I
Zach Amsden has uploaded a new patch set (#12).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 11:
(5 comments)
> I have not updated the Python test yet, as that would require a
> rebase. Python test
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 11:
I have not updated the Python test yet, as that would require a rebase. Python
test and benchmark wi
Zach Amsden has uploaded a new patch set (#11).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h
File be
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc
File be/src/exprs/liter
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h
File be
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 9:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/5951/10//COMMIT_MSG
Commit Message:
PS10, Line 10:
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 10:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5951/10//COMMIT_MSG
Commit Message:
PS10, Line 10: S
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 9:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/decimal-operators-ir.cc
File be/src
Zach Amsden has uploaded a new patch set (#10).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMA
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/runtime/decimal-value.inline.h
File be/s
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 9:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/decimal-operators-ir.cc
File be/
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 9:
(10 comments)
How about augmenting test_decimal_casts.py to also test these cases? (You'll
probably wan
Zach Amsden has uploaded a new patch set (#9).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMAL
Zach Amsden has uploaded a new patch set (#8).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMAL
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc
File be/src/exprs/lite
Zach Amsden has uploaded a new patch set (#7).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMAL
Zach Amsden has uploaded a new patch set (#6).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMAL
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc
File be/src
Zach Amsden has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 5:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc
File be/s
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 5:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc
File be/src
Zach Amsden has uploaded a new patch set (#5).
Change subject: IMPALA-2020: Add rounding for decimal casts
..
IMPALA-2020: Add rounding for decimal casts
This change adds support for DECIMAL_V2 rounding behavior for both
DECIMAL
36 matches
Mail list logo
