[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 6: Code-Review+2 Glad we have automated checking for

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 6: Sorry I forgot to handle some error. -- To view,

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#6). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#5). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 4: Code-Review+2 (4 comments) Looks good, just did a

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 4: Tim, can you do the +2 review for this one? -- To view,

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#4). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 3: Code-Review+1 (2 comments) Change looks good to me -

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#3). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 2: (5 comments) The code change looks good, just needs

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 2: Reimplemented according to the above discussion. --

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#2). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/8385 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Abandoned Sorry this should be in https://gerrit.cloudera.org/c/8226/ -- To

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8385 Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. IMPALA-2758: Remove BufferedTupleStream::GetRows This patch removes