[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option Adds support for a "max_row_size" query option that instructs Impala to

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/7629/14//COMMIT_MSG Commit Message: Line 26: per read and

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1125/ -- To view, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: Tweaked the tests to use less memory. I can now run them locally in parallel without OOMing. -- To view,

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7629 to look at the new patch set (#14). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 13: Oh I see. Seems like a valid optimisation. I'm not sure how broadly applicable it is and I think there are

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 13: > It doesn't seem too necessary to increase max_row_size > automatically. The default will fit 32k 16-byte

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 13: It doesn't seem too necessary to increase max_row_size automatically. The default will fit 32k 16-byte

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 13: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7629 to look at the new patch set (#13). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 12: Code-Review+2 Please see if Alex wants to look at fe. When the row is fixed size, should we use the min of that

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 11: (6 comments) http://gerrit.cloudera.org:8080/#/c/7629/11//COMMIT_MSG Commit Message: PS11, Line 18: The

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option Adds support for a "max_row_size" query option that instructs Impala to reserve enough

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 11: (6 comments) http://gerrit.cloudera.org:8080/#/c/7629/11//COMMIT_MSG Commit Message: PS11, Line 18: The default

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7629/10/common/thrift/PlanNodes.thrift File

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 10: (3 comments) Starting with my first high level question as I may be missing something

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 10: Rebased -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option Adds support for a "max_row_size" query option that instructs Impala to reserve enough

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it and it is behaving

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7629/8//COMMIT_MSG Commit Message: Line 9: This is a preview

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 8: (1 comment) I wasn't planning to add extra tests at this stage. I will try to tweak the current tests so they

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 8: Does this one have all the tests yet, or do you plan to add more still? -- To view, visit

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it and it is behaving

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3208: max_row_size option .. IMPALA-3208: max_row_size option This is a preview because it is missing tests. I have manually tested it and it is behaving