[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5026 To unsubscribe, v

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for K

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 8: Code-Review+2 Minor test fix and rebase. Carry Alex's +2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#8). Change subject: IMPALA-3726: Add support for Kudu-specific column options

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 7: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-ge

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 7: Code-Review+2 (2 comments) Rebase and fixing tests, carry Alex's +2 http://ge

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#7). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 6: Code-Review+2 (2 comments) +2 FE, +1 Catalog http://gerrit.cloudera.org:8080/#/c/5026/5/f

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/5026/5/fe/src/main/cup/sql-pa

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5026/5/fe/src/main/cup/sql-parser.cup Fil

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 5: Modifications to the parser to handle the DEFAULT keyword. -- To view, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/4/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/4/fe/src/main/cup/sql-par

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5026/4/fe/src/main/cup/sql-parser.cup Fil

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 4: Changes the parser to use the DEFAULT keyword without breaking compatibility (

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (3 comments) Looks pretty good, will continue tomorrow. http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/java/org/ap

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/cup/sql-pa

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (4 comments) Responding to comments. http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/ma

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (25 comments) Still need to address the parser changes wrt the use of DEFAULT

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column options This commit adds support for Kudu-sp

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: (29 comments) http://gerrit.cloudera.org:8080/#/c/5026/1/common/thrift/CatalogObjects.thri

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 1: No e2e tests with inserts yet as there seems to be an issue with Kudu wrt hand

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5026 Change subject: IMPALA-3726: Add support for Kudu-specific column options .. IMPALA-3726: Add support for Kudu-specific column op