[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer Change-Id:

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+2 I see, thanks. (Maybe the second case is easier to reproduce by writing

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Please see https://issues.cloudera.org/browse/IMPALA-4371 It seems that Gerrit

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Oh, oops, I wasn't noticing this was the writier. In that case, > why are these

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Do you have access to the file to repro'ed this in the wild? And > given that

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+2 > > Is it reasonably possible to create a file that demonstrates this >

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-03 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: > Is it reasonably possible to create a file that demonstrates this > and can be

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Sorry about that, should've known you were on vacation! -- To view, visit

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4835 To

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. Patch Set 2: What about Dan's comment about the test. It would be great to add a regression

[Impala-ASF-CR] IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer

2016-10-26 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has uploaded a new patch set (#2). Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer .. IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer Change-Id: