[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 5: Code-Review+2 (2 comments) Carry +2, last patch didn't include the small test changes needed to

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-23 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add RuntimeState::Close() which is guaranteed to

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-23 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-23 Thread Henry Robinson (Code Review)
Hello Internal Jenkins, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4893 to look at the new patch set (#5). Change subject: IMPALA-4410: Safer tear-down of RuntimeState

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/4/be/src/runtime/runtime-state.h File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 4: Code-Review+2 Rebase. -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe,

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4893 to look at the new patch set (#4). Change subject: IMPALA-4410: Safer tear-down of RuntimeState ..

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4893 to look at the new patch set (#3). Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410:

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-03 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Abandoned Yeah that's weird - the Change-Id's in the wrong place. -- To view, visit

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: Dup of https://gerrit.cloudera.org/#/c/4893/ ? -- To view, visit http://gerrit.cloudera.org:8080/4910

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4910 Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4893 Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add