[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6955 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/779/ -- To view, visit

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Code-Review+2 Rebased, carrying forward -- To view, visit

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6955 to look at the new patch set (#10). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6955/8/common/thrift/JniCatalog.thrift File

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6955 to look at the new patch set (#9). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6955/8/common/thrift/JniCatalog.thrift File

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6955 to look at the new patch set (#8). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6955 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 5: (18 comments) > We should add an e2e test that exhaustively tests all combinations > of

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 4: We should add an e2e test that exhaustively tests all combinations of column type, encoding and

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 4: (18 comments)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 3: So I simplified this by representing it as a CHANGE operation in the catalog. I think that it

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 2: > To be a bit more prescriptive than my last comment: > > Can you see how much of this new

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 2: To be a bit more prescriptive than my last comment: Can you see how much of this new functionality

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6955/1//COMMIT_MSG Commit Message: Line 8: Need to

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's default value

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-05-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6955 Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the