Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7363
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/934/
--
To
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7363
To unsubscribe,
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 11:
(2 comments)
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7363
to look at the new patch set (#12).
Change subject: IMPALA-5511: Add process start time to debug web page
..
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 9:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/7363/9/be/src/statestore/statestore.cc
Gabor Kaszab has uploaded a new patch set (#11).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 9:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7363/9/be/src/statestore/statestore.cc
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 8:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7363/8/be/src/catalog/catalog-server.cc
Gabor Kaszab has uploaded a new patch set (#9).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 8:
(7 comments)
Looks a lot better! I think we can get rid of some duplication if you
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 6:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7363/6/be/src/util/metrics.cc
File
Gabor Kaszab has uploaded a new patch set (#7).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 6:
(6 comments)
I think the code would be cleaner if the metric always had the same name -
Gabor Kaszab has uploaded a new patch set (#6).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 5:
To that end, it might be better to define a single process-start-time metric,
and to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 5:
Can you add this information to the root (/) web page for each daemon? I think
it's very
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 5:
comments incorporated
--
To view, visit http://gerrit.cloudera.org:8080/7363
To
Gabor Kaszab has uploaded a new patch set (#4).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Gabor Kaszab has uploaded a new patch set (#5).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
> Sure, I'll create a similar start-time metric for this 2 processes
> as well. Some
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
Sure, I'll create a similar start-time metric for this 2 processes as well.
Some question
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
Yeah I think we should avoid reporting two different values for sure. Maybe we
should
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
> Yeah I think we should avoid reporting two different values for
> sure. Maybe we
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
> Thanks Matt, that's a good point. We should probably just display
> that metric's
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
Thanks Matt, that's a good point. We should probably just display that metric's
value
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 3:
We also have a metric (see http endpoint /metrics) called
"impala-server.start-time",
Gabor Kaszab has uploaded a new patch set (#3).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Gabor Kaszab has uploaded a new patch set (#3).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Gabor Kaszab has uploaded a new patch set (#2).
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web page
Read the start date and time of the impalad,
Gabor Kaszab has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7363/1/be/src/util/process-state-info.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 1:
(2 comments)
The overall approach seems good, but I had some concerns about the
gaborkas...@cloudera.com has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7363
Change subject: IMPALA-5511: Add process start time to debug web page
..
IMPALA-5511: Add process start time to debug web
34 matches
Mail list logo
