[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe,

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. IMPALA-5560: always store CHAR(N) inline in tuple This is done to simplify the CHAR(N)

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/815/ -- To

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 7: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe,

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7303 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7303 to look at the new patch set (#6). Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. IMPALA-5560:

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7303/3/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 5: Code-Review+2 Meant to +2 but please see previous comment. -- To view, visit

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7303/3/be/src/exec/parquet-column-readers.cc File

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 5: A couple of tests referred to the in/out-of-line char optimisation in comments. Fixed those.

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. IMPALA-5560: always store CHAR(N) inline in tuple This is done to simplify the CHAR(N) logic. I believe this

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. IMPALA-5560: always store CHAR(N) inline in tuple This is done to simplify the CHAR(N) logic. I believe this

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/hash-table.cc File

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. Patch Set 2: (2 comments) nice http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/hash-table.cc File

[Impala-ASF-CR] IMPALA-5560: always store CHAR(N) inline in tuple

2017-06-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5560: always store CHAR(N) inline in tuple .. IMPALA-5560: always store CHAR(N) inline in tuple This is done to simplify the CHAR(N) logic. I believe this