[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-11-15 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 6: Based on the conversation on dev@

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-31 Thread Kim Jin Chul (Code Review)
Hello Greg Rahn, Jim Apple, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#6). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-30 Thread Kim Jin Chul (Code Review)
Hello Greg Rahn, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#5). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-30 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 4: (3 comments) Let's figure out how to

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-30 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-30 Thread Kim Jin Chul (Code Review)
Hello Greg Rahn, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#4). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-27 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-27 Thread Kim Jin Chul (Code Review)
Hello Greg Rahn, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8311 to look at the new patch set (#3). Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Looks like we want NANOSECONDS after all,

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (6 comments) Overall this looks good -

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-19 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2017-10-19 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8311 Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. IMPALA-5607: Add additional units to EXTRACT,