Dan Hecht has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 6:
> I wrote up a short page on the wiki per Henry's suggestion:
>
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
IMPALA-5715: (mitigation only) defer destruction of MemTrackers
One
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7492
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1016/
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 5: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7492
To
Hello Michael Ho, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7492
to look at the new patch set (#5).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
ASAN build was clean but hit flaky test IMPALA-5773.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(5 comments)
Addressed the comments. Was in the middle of a rebase onto the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
Going to run tests under ASAN before merging
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7492
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(2 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4: Code-Review+2
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 4:
(3 comments)
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7492
to look at the new patch set (#4).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 3:
(3 comments)
LGTM. Please address the question in ~MemTracker().
Michael Ho has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 3:
Thanks for updating it. Will do a pass today.
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 3: Code-Review+1
(3 comments)
Looks good to me. Lets see if Michael wants to take
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7492
to look at the new patch set (#3).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
(4 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
(4 comments)
Maybe I've been staring at this too long, but why do we have
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
> The conclusion was that it was very difficult to reason about the
> lifetime
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
The conclusion was that it was very difficult to reason about the lifetime of
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
> That was a bit more involved than expected, but all MemTrackers
> should now
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
Patch Set 2:
That was a bit more involved than expected, but all MemTrackers should now have
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers
..
IMPALA-5715: (mitigation only) defer destruction of MemTrackers
One potential candidate for the
25 matches
Mail list logo
