[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 4: > When did we decide that the change in the comment was one we > wanted? For one, I prefer havi

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 4: When did we decide that the change in the comment was one we wanted? For one, I prefer hav

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Match .clang-format more closely to actual practice. .. Match .clang-format more closely to actual practice. In order to attempt to get code like doubl

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 3: Verified+1 Can't break tests with this change, so +1 verify manually -- To view, visit http://

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 3: Code-Review+2 rebase, carry +1 into +2 -- To view, visit http://gerrit.cloudera.org:8080/4590

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > > I'm not sure I understand why a person might want to run the > inferencer again, even if th

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > I'm not sure I understand why a person might want to run the inferencer > again, even if

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: > Do you understand the relationship between the resulting > .clang-format file and the changes

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: Do you understand the relationship between the resulting .clang-format file and the change

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4590 To unsubscribe, visit

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4590/1/.clang-format File .clang-format: Line

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Match .clang-format more closely to actual practice. .. Match .clang-format more closely to actual practice. In order to attempt to get code like double VeryLongF

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4590/1/.clang-format File .clang-format:

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 1: See https://gerrit.cloudera.org/#/c/4591 for the example diffs -- To view, visit http://gerrit

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-02 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4590 Change subject: Match .clang-format more closely to actual practice. .. Match .clang-format more closely to actual practice. In order to att