[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5382 to review the following change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 1: Kicked off a build here:

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-06 Thread Alex Behm (Code Review)
Hello Impala Public Jenkins, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5324 to look at the new patch set (#6). Change subject: IMPALA-4574: Do not treat UUID() like a constant expr.

[Impala-ASF-CR] IMPALA-4585: Replace file paths with HDFS FILENAME in expected exceptions

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5372/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4586: don't constant fold in backend

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4586: don't constant fold in backend .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/5391/3//COMMIT_MSG Commit Message: Line 15: constant

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 3: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4595: Ignore discarded functions after linking

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4595: Ignore discarded functions after linking .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5384/1/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-4566: Set Kudu vlog level independently of Impala vlog

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5393 Change subject: IMPALA-4566: Set Kudu vlog level independently of Impala vlog .. IMPALA-4566: Set Kudu vlog level independently of

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE This commit also removes the

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. IMPALA-4592: Improve error msg for non-deterministic predicates. Impala cannot

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5386 To

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5382 to look at the new patch set (#3). Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-4586: don't constant fold in backend

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4586: don't constant fold in backend .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5391/3//COMMIT_MSG Commit Message: Line 14: offers

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5369 To unsubscribe,

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: FYI I've sent Todd an e-mail (he's in Singapore) asking why he thinks this isn't

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5394

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5394 Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. IMPALA-4613: Make sure timers are finished

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add flag for Kudu read-your-writes The previous attempt to support for Kudu

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5288 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4585: Allow the $DATABASE template in the CATCH section

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4585: Allow the $DATABASE template in the CATCH section .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5372 To unsubscribe,

[Impala-ASF-CR] IMPALA-4585: Allow the $DATABASE template in the CATCH section

2016-12-06 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5372 to look at the new patch set (#3). Change subject: IMPALA-4585: Allow the $DATABASE template in the CATCH section ..

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-06 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 2: (26 comments) http://gerrit.cloudera.org:8080/#/c/5093/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5386 to look at the new patch set (#5). Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates.

[Impala-ASF-CR] IMPALA-4585: Replace HDFS FILENAME with actual paths

2016-12-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4585: Replace __HDFS_FILENAME__ with actual paths .. IMPALA-4585: Replace __HDFS_FILENAME__ with actual paths In a recent change (IMPALA-4363) we

[Impala-ASF-CR] IMPALA-4586: don't constant fold in backend

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5391 Change subject: IMPALA-4586: don't constant fold in backend .. IMPALA-4586: don't constant fold in backend Before this patch, the

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 7: (15 comments) http://gerrit.cloudera.org:8080/#/c/4418/7/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-4613: Make sure timers are finished before sending report profile

2016-12-06 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4613: Make sure timers are finished before sending report profile .. IMPALA-4613: Make sure timers are finished before sending report profile

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. IMPALA-4592: Improve error msg for non-deterministic predicates. Impala cannot correctly evaluate

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5390 Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu

[Impala-ASF-CR] IMPALA-3314: Fix Avro schema loading for partitioned tables.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3314: Fix Avro schema loading for partitioned tables. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5388 To unsubscribe,

[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5392 Change subject: IMPALA-4609: prefix thread counters in fragment profile .. IMPALA-4609: prefix thread counters in fragment profile This

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. IMPALA-2864: Ensure that client connections are closed after a

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4585: Replace HDFS FILENAME with actual paths

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4585: Replace __HDFS_FILENAME__ with actual paths .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5372/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 1: Thanks, Lars! So firstly, this functionality I think is pretty important so worth

[Impala-ASF-CR] IMPALA-4585: Replace HDFS FILENAME with actual paths

2016-12-06 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4585: Replace __HDFS_FILENAME__ with actual paths .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5372/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5390/1/common/thrift/Frontend.thrift

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#8). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5369 To unsubscribe,

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. IMPALA-4477: Bump Kudu version to latest master (60aa54e) Bumps the toolchain version

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: -Code-Review Hm maybe the issue is still there, I thought it was fixed but Todd

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5324 To unsubscribe, visit

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 3: I submitted this for a gvo:

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE This commit also removes the now unused

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/1/be/src/exec/kudu-scanner.cc File

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/2/be/src/exec/kudu-scanner.cc

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5288 to look at the new patch set (#3). Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788:

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-06 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#5). Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific Removes some of the

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 5: I have substantially reduced the documentation changes after our out-of-band

[Impala-ASF-CR] Add Apache license header to files in doc directory

2016-12-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add Apache license header to files in doc directory .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG Commit Message: PS2,

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5386 Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. IMPALA-4592: Improve error msg for non-deterministic

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5386/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-06 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/5387 Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. IMPALA-4355: random query

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. IMPALA-4592: Improve error msg for non-deterministic predicates. Impala cannot correctly evaluate

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. IMPALA-4592: Improve error msg for non-deterministic predicates. Impala cannot correctly evaluate

[Impala-ASF-CR] IMPALA-4592: Improve error msg for non-deterministic predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4592: Improve error msg for non-deterministic predicates. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5386/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 1: > Uploaded patch set 1. Ran a private build and it passed

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5377 Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. IMPALA-4594: WriteSlot and

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5317 To

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-12-06 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#4). Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. IMPALA-2057: Better error message for incorrect avro decimal column declaration

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. IMPALA-2925: Mark test_alloc_update as xfail. test_alloc_update.py is flaky and the expected

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5366 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add flag for Kudu read-your-writes The previous attempt to support for Kudu 'read-your-writes'

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4595: Ignore discarded functions after linking

2016-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5384 Change subject: IMPALA-4595: Ignore discarded functions after linking .. IMPALA-4595: Ignore discarded functions after linking For LLVM IR

[Impala-ASF-CR] IMPALA-4595: Ignore discarded functions after linking

2016-12-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4595: Ignore discarded functions after linking .. Patch Set 1: (1 comment) Code change looks good

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. IMPALA-3126: Conservative assignment of inner-join On-clause predicates. Implements the

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. IMPALA-4574: Do not treat UUID() like a constant expr. A recent change (IMPALA-1788) lead

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5324 To unsubscribe,

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 2: FYI I submitted a private jenkins test run for this change:

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5385 to look at the new patch set (#3). Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open()

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. Patch Set 3: Code-Review+2 (2 comments) Rebase. Carry +2.

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5385 Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. IMPALA-2864: Ensure that client

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 2: PS2 build:

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. IMPALA-2864: Ensure that client connections are closed after a failed Open() When

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5382 To

[Impala-ASF-CR] IMPALA-2864: Ensure that client connections are closed after a failed Open()

2016-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2864: Ensure that client connections are closed after a failed Open() .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-06 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific This fix is a prototype

[Impala-ASF-CR] IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently

2016-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4594: WriteSlot and CodegenWriteSlot handle escaped NULL slots differently .. Patch Set 2: (3 comments)

  1   2   >