[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. IMPALA-4750: Rename test infra classes so they don't mimic test classes. This patch

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: Code-Review+1 (4 comments) Just a few minor things from my point of view.

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5784 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5584 to look at the new patch set (#18). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: (1 comment) > (4 comments) > > Just a few minor things from my point of

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-26 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 8: (1 comment) > (2 comments) > > If you want to add the config values to

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Remove 'without Cloudera Manager' from two titles .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5749 To unsubscribe,

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Remove 'without Cloudera Manager' from two titles .. Remove 'without Cloudera Manager' from two titles Change-Id:

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 9: > (1 comment) > > > (2 comments) > > > > If you want to add the config

[Impala-ASF-CR] Add nested testdata flattener

2017-01-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add nested testdata flattener .. Patch Set 1: Nice! I'll be taking a look at this today. -- To view, visit http://gerrit.cloudera.org:8080/5787 To

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 6: In the interest of making some progress (but more so trying out

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/218/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 1: (1 comment) I think you need a new finalize function to separate stddev

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Remove 'without Cloudera Manager' from two titles .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/24/ -- To view,

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 3: > > (1 comment) > > > > I did my own survey for this renaming and feel

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 3: Yup. I addressed Michael's request with regard to updating the commit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 22: Code-Review+1 (2 comments) Catalog changes look

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 4: Build started:

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Major update to Impala + Kudu page .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5649/11/docs/topics/impala_create_table.xml File

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5794 To

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/5800 Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. IMPALA-4738: STDDEV_SAMP should return NULL for

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5791 To

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation. Simple

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/217/ --

[Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. IMPALA-4792: Fix number of distinct values for a CASE with constant outputs If all

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 18: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5584 To

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97

[Impala-ASF-CR] IMPALA-4829: Change default Kudu read behavior for "RYW"

2017-01-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5802 Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW" .. IMPALA-4829: Change default Kudu read behavior for "RYW"

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#3). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Add doc for MT DOP query option.

2017-01-26 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: Add doc for MT_DOP query option. .. Add doc for MT_DOP query option. Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92 --- M docs/impala.ditamap M

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-26 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: [DOCS] Add doc for MT_DOP query option. .. [DOCS] Add doc for MT_DOP query option. Add info about MT_DOP default to COMPUTE STATS. Change-Id:

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (13 comments)

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-26 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5652/3/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] [DOCS] Major update to Impala + Kudu page

2017-01-26 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#12). Change subject: [DOCS] Major update to Impala + Kudu page .. [DOCS] Major update to Impala + Kudu page Upgrade with details of latest syntax. Fine-tune discussion of PK and

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-26 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (16 comments) http://gerrit.cloudera.org:8080/#/c/5668/1//COMMIT_MSG Commit Message: Line 28: Change-Id:

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-26 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: Release note updates for Impala 2.8 .. Release note updates for Impala 2.8 First cut at 'new features' topic. Includes the Incompatible Changes subtopic for

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. IMPALA-3909: Populate min/max statistics in Parquet writer Change-Id:

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 6: (13 comments) Thanks for the review. Please see PS7.

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-26 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5807 Change subject: Add "Known Issues" item for IMPALA-4828. .. Add "Known Issues" item for IMPALA-4828. Change-Id:

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 1: (2 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5801 Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Create global BufferPool at startup.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#2). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. IMPALA-4750: Rename test infra classes so they don't mimic test

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5667/8//COMMIT_MSG Commit Message:

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 9: A reminder to us both: the first blog post should change the Blog header link to

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#9). Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the site is

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 9: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5667 To

[Impala-ASF-CR] IMPALA-4829: Change default Kudu read behavior for "RYW"

2017-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW" .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5802 To