[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-09-11 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#7). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. IMPALA-4848: Add WIDTH_BUCKET() function Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f --- M

[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4082: Remove todo item in getRegionsInRange .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8018 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7849

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-11 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 7: I tested this locally on my machine with a cluster size = 1. I was

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-4082: Remove todo item in getRegionsInRange

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4082: Remove todo item in getRegionsInRange .. Patch Set 1: Code-Review+1 Thank you for fixing this. -- To view, visit

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() This change codegen outs

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 2: (12 comments) Change is looking pretty good to me, only minor comments left.

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7849 To

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 1: (10 comments) Nice, thanks for working on this one

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. IMPALA-3642: Adding backend addresses to error statuses

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#17). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 2: (4 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-3437: DECIMAL V2: avoid implicit decimal->double conversion

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion .. PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion This

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 16: (14 comments)

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] PREVIEW: IMPALA-3437: DECIMAL V2: avoid implicit decimal->double conversion

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion .. PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion This

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8015 To

[Impala-ASF-CR] IMPALA-4987: Fix flaky test test row availability.py

2017-09-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8036 Change subject: IMPALA-4987: Fix flaky test test_row_availability.py .. IMPALA-4987: Fix flaky test test_row_availability.py This patch

[Impala-ASF-CR] IMPALA-5894: [DOCS] Clarify placement of STRAIGHT JOIN hint

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8031 To unsubscribe,

[Impala-ASF-CR] IMPALA-4987: Fix flaky test test row availability.py

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4987: Fix flaky test test_row_availability.py .. Patch Set 1: (13 comments) Thanks for fixing this http://gerrit.cloudera.org:8080/#/c/8036/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. IMPALA-5912: fix crash in trunc(..., "WW") in release build The bug is with the

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5250: Unify decompressor output_length semantics .. Patch Set 1: (18 comments) http://gerrit.cloudera.org:8080/#/c/8030/1//COMMIT_MSG Commit Message: Line

[native-toolchain-CR] Bump Kudu version to 3f49724

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/8028 Change subject: Bump Kudu version to 3f49724 .. Bump Kudu version to 3f49724 Change-Id:

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 16: (14 comments)

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#3). Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. IMPALA-1767 Adds predicate to test boolean values true, false, unknown. Adds a new

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5894: [DOCS] Clarify placement of STRAIGHT JOIN hint

2017-09-11 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/8031 Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint .. IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8015 To

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8030 Change subject: IMPALA-5250: Unify decompressor output_length semantics .. IMPALA-5250: Unify decompressor output_length semantics This

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/base-sequence-scanner.cc

[native-toolchain-CR] Bump Kudu version to 3f49724

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 3f49724 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8028 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/8029 Change subject: IMPALA-3360: Codegen inserting into runtime filters .. IMPALA-3360: Codegen inserting into runtime filters

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/scanner-context.h File

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: Yeah we could probably add an error code like DISK_IO_MGR_ERROR and use it for the

[native-toolchain-CR] Bump Kudu version to 3f49724

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 3f49724 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8028 To unsubscribe, visit

[native-toolchain-CR] Bump Kudu version to 3f49724

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. Change subject: Bump Kudu version to 3f49724 .. Bump Kudu version to 3f49724 Change-Id: I38334bdbaa1e7a6c6f5d595c26efb76efa062305 --- M buildall.sh 1 file

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/scanner-context.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: > Yeah we could probably add an error code like DISK_IO_MGR_ERROR and > use it for the

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-11 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#6). Change subject: IMPALA-5211: Simplifying ifnull conditional. .. IMPALA-5211:

[Impala-ASF-CR] IMPALA-3642: Adding backend addresses to error statuses for some scratch failures.

2017-09-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-3642: Adding backend addresses to error statuses for some scratch failures. .. IMPALA-3642: Adding backend addresses to error statuses for some scratch

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 6: (22 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 17: (7 comments)

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7901/6/be/src/rpc/rpc-mgr-test.cc File

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Restored Reopen since a new fix is implemented. -- To view, visit

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Abandoned Sorry. Not ready. -- To view, visit http://gerrit.cloudera.org:8080/7949 To

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/base-sequence-scanner.cc

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1210/ --

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. Patch Set 2: Code-Review+1 Making these cases consistent makes sense to me. Really, I think we need to

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5667: Race in DataStremSender could cause TransmitData sidecar corruption

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5667: Race in DataStremSender could cause TransmitData sidecar corruption .. Patch Set 1: Is this something we want to move forward? -- To view, visit

[Impala-ASF-CR] IMPALA-4978: Impala should set the kerberos principal to the FQDN

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4978: Impala should set the kerberos principal to the FQDN .. Patch Set 1: Do we want to move forward with this? -- To view, visit

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8023/1/be/src/runtime/krpc-data-stream-mgr.h File

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. Patch Set 2: Yeah I think there are some fundamental problems with the current parallel startup logic

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 7: Ping? -- To view, visit http://gerrit.cloudera.org:8080/7245 To

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#6). Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. IMPALA-1767 Adds predicate to test boolean values true, false, unknown. Adds a new

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#5). Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. IMPALA-1767 Adds predicate to test boolean values true, false, unknown. Adds a new

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 6: (12 comments)

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#4). Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. IMPALA-1767 Adds predicate to test boolean values true, false, unknown. Adds a new

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-09-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/exec/exec-node.h

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. IMPALA-5920: Remove admission control dependency on YARN RM jar Impala's admission controller

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN resourcemanager

2017-09-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/8035 Change subject: IMPALA-5920: Remove admission control dependency on YARN resourcemanager .. IMPALA-5920: Remove admission control

[Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch()

2017-09-11 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() .. Patch Set 2: (2 comments)