[Impala-ASF-CR] IMPALA-5990: Part 1: JNI-based LZ4 de/compression

2017-09-26 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8150 Change subject: IMPALA-5990: Part 1: JNI-based LZ4 de/compression .. IMPALA-5990: Part 1: JNI-based LZ4 de/compression Adds LZ4

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#3). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected.

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. IMPALA-5975: Work around broken beeline clients To

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 5: (1 comment) > The Parquet writer does

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: I totally agree about doing anything fancy as a

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Lars Volker, Matthew Jacobs, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7793 to look at the new patch set (#5). Change subject: IMPALA-4252: Min-max runtime filters for Kudu

[Impala-ASF-CR] DRAFT - IMPALA-4252: Min-max runtime filters for Kudu

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Lars Volker, Matthew Jacobs, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7793 to look at the new patch set (#4). Change subject: DRAFT - IMPALA-4252: Min-max runtime filters for Kudu

[Impala-ASF-CR] IMPALA-4252: Move runtime filters to ScanNode

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8148 Change subject: IMPALA-4252: Move runtime filters to ScanNode .. IMPALA-4252: Move runtime filters to ScanNode As a

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8140 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. IMPALA-5376: Implement all TPCDS test cases or

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 6: I think we should explore your suggestion to

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/7438 ) Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4940: Decimal V2 multiplication Implement

[Impala-ASF-CR] IMPALA-5986: Allow SET option names to contain digits when resetting them between queries.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8140 ) Change subject: IMPALA-5986: Allow SET option names to contain digits when resetting them between queries. .. IMPALA-5986: Allow SET option

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8123 ) Change subject: IMPALA-5870: Improve runtime profile for partial sort .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-26 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8085 to look at the new patch set (#6). Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-09-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 5: (8 comments)

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

2017-09-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8136 ) Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE. .. Patch Set 1: (26 comments) First pass. High level approach

[Impala-ASF-CR] IMPALA-5448: fix invalid number of splits reported in Parquet scan node

2017-09-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8147 Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node .. IMPALA-5448: fix invalid number of splits

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 2: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940: Avoid log spew by using Status::Expected. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Hello Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8100 to look at the new patch set (#2). Change subject: IMPALA-5940: Avoid log spew by using Status::Expected.

[Impala-ASF-CR] IMPALA-5940. Avoid log spew by using Status::Expected.

2017-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8100 ) Change subject: IMPALA-5940. Avoid log spew by using Status::Expected. .. Patch Set 1: (1 comment) Thanks for the review! I added

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: Thanks for testing! Still lgtm. -- To view, visit

[Impala-ASF-CR] IMPALA-5975: Work around broken beeline clients

2017-09-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8132 ) Change subject: IMPALA-5975: Work around broken beeline clients .. Patch Set 1: >From private build and test 6418, 14:21:05 Executing:

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-09-26 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException issue .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-09-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8143 Change subject: IMPALA-4682 Fix IllegalStateException issue .. IMPALA-4682 Fix IllegalStateException issue When one runs a query like

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. IMPALA-5538: Use explicit catalog

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8123 ) Change subject: IMPALA-5870: Improve runtime profile for partial sort .. Patch Set 3: The GVO failed because there was a kudu

[Impala-ASF-CR] IMPALA-5870: Improve runtime profile for partial sort

2017-09-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8123 to look at the new patch set (#3). Change subject: IMPALA-5870: Improve runtime profile for partial sort

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8140 ) Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. IMPALA-5376: Implement all TPCDS test cases or

[Impala-ASF-CR] Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has restored this change. ( http://gerrit.cloudera.org:8080/8140 ) Change subject: Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests. ..

[Impala-ASF-CR] [DOCS] Fill in release note subtopics for Apache Impala 2.10

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7958 ) Change subject: [DOCS] Fill in release note subtopics for Apache Impala 2.10 .. [DOCS] Fill in release note subtopics

[Impala-ASF-CR] [DOCS] Fill in release note subtopics for Apache Impala 2.10

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7958 ) Change subject: [DOCS] Fill in release note subtopics for Apache Impala 2.10 .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Fill in release note subtopics for Apache Impala 2.10

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7958 ) Change subject: [DOCS] Fill in release note subtopics for Apache Impala 2.10 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-09-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 1: (5 comments)

[Impala-ASF-CR] Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has abandoned this change. ( http://gerrit.cloudera.org:8080/8140 ) Change subject: Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests. ..

[Impala-ASF-CR] Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests.

2017-09-26 Thread Tim Wood (Code Review)
Tim Wood has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8140 Change subject: Trial run to suppress fractional comparison diffs. Still not sure of the general approach for DOUBLE & DECIMAL in all tests.

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-26 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8056 to look at the new patch set (#5). Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-26 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 ) Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 8: Code-Review+2 Rebase and keep

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 1: Thanks for fixing this. Can you add

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8139 Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. IMPALA-5983: Fix crash in

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8076 ) Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-09-26 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8076 to look at the new patch set (#3). Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786: