[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 4: (7 comments) Looking pretty good.

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 10: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-09-29 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#5). Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. IMPALA-889: Add support for an ISO-SQL compliant trim() function. Purpose: Removes all

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-09-29 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#4). Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. IMPALA-889: Add support for an ISO-SQL compliant trim() function. Purpose: Removes all

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 12: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/4350

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/4350/11/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#12). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4558 To

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Remove spurious Boost warnings on compilation errors .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit

[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Remove spurious Boost warnings on compilation errors .. Remove spurious Boost warnings on compilation errors Compilation errors can spuriously print

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 11: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 3: Taras also verified the fix works with the same query. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe,

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-3786: Replace "cloudera" with "apache" (part 2) As part of the ASF transition, we

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3936 To unsubscribe,

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. IMPALA-3786: Replace "cloudera" with "apache" (part 1) As part of the ASF transition, we

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 3: > (1 comment) Taras, were you also able to verify that the fix solves the

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4557 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-29 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4448 to look at the new patch set (#4). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 4: Code-Review+2 Missed updating a DCHECK for the nested types codepath. -- To view,

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 3: Code-Review+1 (1 comment) Carry +1

[Impala-ASF-CR] Don't assume that AUX exists just because a shell variable is set

2016-09-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Don't assume that AUX exists just because a shell variable is set .. Patch Set 1: I tested this when AUX is present; it passed. I'm now testing when AUX is

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-29 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors

2016-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove spurious Boost warnings on compilation errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4564 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Remove spurious Boost warnings on compilation errors

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4564 Change subject: Remove spurious Boost warnings on compilation errors .. Remove spurious Boost warnings on compilation errors

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ HdfsScanNodeBase::Close()

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 6: Code-Review+2 Carry ALex's +2 -- To view, visit http://gerrit.cloudera.org:8080/3937 To

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 5: Code-Review+2 Carry ALex's +2 -- To view, visit http://gerrit.cloudera.org:8080/3936 To

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 6: Code-Review+1 Rebased, carrying forward +1s. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: (2 comments)

[Impala-ASF-CR] Don't assume that AUX exists just because a shell variable is set

2016-09-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Don't assume that AUX exists just because a shell variable is set .. Patch Set 1: Testing now. I expect the tests to take a few hours. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 5: Code-Review+1 Rebased, carrying forward +1s. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#6). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3936 to look at the new patch set (#5). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1)

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4557 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 2: Sry missed the test. Added it in PS2. -- To view, visit

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-29 Thread Bharath Vissapragada (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4557 to look at the new patch set (#2). Change subject: IMPALA-4196: Cross compile bit-byte-functions .. IMPALA-4196:

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/4/bin/bootstrap_toolchain.py

[Impala-ASF-CR] Add vim-specific files to .gitignore

2016-09-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add vim-specific files to .gitignore .. Patch Set 1: Code-Review+2 (2 comments) Seems reasonable. http://gerrit.cloudera.org:8080/#/c/4562/1/.gitignore File

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 3: (8 comments) Some comments before I head off to Strata. I would

[Impala-ASF-CR] IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

2016-09-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 5: (24 comments) Thanks for all the help so far. I created a bunch of upstream Jiras

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4206: Add column lineage regression test. .. IMPALA-4206: Add column lineage regression test. The underlying issue was already fixed in

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4350/7/be/src/util/blocking-queue.h

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#11). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue ..

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ HdfsScanNodeBase::Close()