[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#25). Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. IMPALA-3202,IMPALA-2079: rework scratch file I/O Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 24: (6 comments) http://gerrit.cloudera.org:8080/#/c/5141/24//COMMIT_MSG Commit Message: PS24,

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5596 To

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: (2 comments) > (1 comment) > > This is the sort of cleanup work that I

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4689: Fix computation of last active time .. Patch Set 2: Code-Review+2 (1 comment) Test changes look code aside from one minor comment.

[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5596 Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Take out (stale) architecture diagram w/

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-03 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5591

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4689: Fix computation of last active time .. Patch Set 2: Code-Review+2 Someone else should +2 the test changes. -- To view, visit

[Impala-ASF-CR] DOCS-1757

2017-01-03 Thread Anonymous Coward (Code Review)
ambreen.k...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/5594 Change subject: DOCS-1757 .. DOCS-1757 Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16 --- M

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe,

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-03 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5545 to look at the new patch set (#3). Change subject: IMPALA-4653: fix sticky config variable problem .. IMPALA-4653:

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4653: fix sticky config variable problem .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5545/2/bin/impala-config-branch.sh File

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. Patch Set 1: (13 comments)

[Impala-ASF-CR] IMPALA-4192: Avoid updating Expr's states from ExprContext

2017-01-03 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext .. IMPALA-4192: Avoid updating Expr's states from ExprContext This change cleans up some entangled logic

[Impala-ASF-CR] add thousands separator to cardinality

2017-01-03 Thread Greg Rahn (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5587 to look at the new patch set (#3). Change subject: add thousands separator to cardinality .. add thousands

[Impala-ASF-CR] add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators

2017-01-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators .. Patch Set 2: (1 comment)

[Impala-ASF-CR] add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators

2017-01-03 Thread Greg Rahn (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5587 to look at the new patch set (#2). Change subject: add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #268 has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: Code-Review+1 Thanks for the doc update! -- To view, visit

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#24). Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. IMPALA-3202,IMPALA-2079: rework scratch file I/O Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic

[Impala-ASF-CR] add thousands seperator to cardinality

2017-01-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: add thousands seperator to cardinality .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5587 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/5141/23/be/src/runtime/tmp-file-mgr.cc File

[Impala-ASF-CR] add thousands seperator to cardinality

2017-01-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: add thousands seperator to cardinality .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5587/1//COMMIT_MSG Commit Message: PS1, Line 7:

[Impala-ASF-CR] IMPALA-4653: fix sticky config variable problem

2017-01-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4653: fix sticky config variable problem .. Patch Set 2: (2 comments) thanks! http://gerrit.cloudera.org:8080/#/c/5545/2/bin/impala-config-branch.sh

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4689: Fix computation of last active time .. Patch Set 1: (2 comments) Thanks for the review, please see PS2.

[Impala-ASF-CR] IMPALA-4689: Fix computation of last active time

2017-01-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4689: Fix computation of last active time .. IMPALA-4689: Fix computation of last active time The last active time in impala-server.cc#L1806 is in

[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag, same as in topicref tag.

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5592 Change subject: Apply attribute to hide main data source topic in keydef tag, same as in topicref tag. .. Apply attribute to hide main

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2017-01-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/5491/4/be/src/runtime/data-stream-mgr.cc File

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: (1 comment) This is the sort of cleanup work that I propose being

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5591 Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Remove audience="Cloudera" from DITAVal,

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: I'm ok with this change but I think we should add the logging in case we hit the problem on

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. IMPALA-3973: optional 2nd and 3rd arguments for instr(). Change-Id:

[Impala-ASF-CR] Add explanation and example of negative arg.

2017-01-03 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: Add explanation and example of negative arg. .. Abandoned Created by mistake because 2 commits to private branch. -- To view, visit http://gerrit.cloudera.org:8080/5590

[Impala-ASF-CR] Add explanation and example of negative arg.

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5590 Change subject: Add explanation and example of negative arg. .. Add explanation and example of negative arg. Change-Id:

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5589 Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. IMPALA-3973: optional 2nd and 3rd arguments for instr().

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > > Maybe we should dump out the value of some of these metrics > before > > running the tests in

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 23: (1 comment) Fixed a couple of bugs that I discovered when building things on top of this.