[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5795 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4359: qgen: add UPSERT support .. IMPALA-4359: qgen: add UPSERT support UPSERTs are very similar to INSERTs, so the UPSERT support is

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3785: Record query handle for invalid handle .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5748 To unsubscribe,

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: Code-Review+1 The fix for the UDA arg type makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/237/ -- To view, visit

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to be working with some really big numbers that

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 5: Code-Review+2 (2 comments) Before you merge, let me ask Dan to take a quick look to see if

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 24: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5902 Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers We're going to

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5889 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option This query option is going to be used to change both

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 3: Code-Review+1 Thanks, I think there are some helpful improvements

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may crash on read Creating a table in Impala,

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. IMPALA-1427: Improvements to "Unknown disk-ID" warning This commit, - Removes the runtime

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 4: (6 comments)

[Impala-ASF-CR] [DOCS] Release note updates for Impala 2.8

2017-02-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: [DOCS] Release note updates for Impala 2.8 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/6/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3785: Record query handle for invalid handle .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/236/ -- To

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3785: Record query handle for invalid handle .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5748/5/tests/hs2/test_hs2.py File

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5900 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Genericize HBase page .. [DOCS] Genericize HBase page 2x links that point to archive.cloudera.com mirror of HBase docs, point to Apache

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: Code-Review+2 (4 comments) Looks good to me but see if Marcel wants to take another pass.

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: Code-Review+2 This will pave the way for a big link-genericizing CR, concentrated in that impala_keydefs.ditamap

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/35/ -- To view, visit

[Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize HBase topic, esp links

2017-02-03 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: IMPALA-4643: [DOCS] Genericize HBase topic, esp links .. Abandoned Abandoning in favor of https://gerrit.cloudera.org/#/c/5900/ -- To view, visit

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5900 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: I'm abandoning the duplicate review https://gerrit.cloudera.org/#/c/5858/1 because the one here is getting better

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5900/1/docs/topics/impala_hbase.xml File

[Impala-ASF-CR] [DOCS] Release note updates for Impala 2.8

2017-02-03 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#9). Change subject: [DOCS] Release note updates for Impala 2.8 .. [DOCS] Release note updates for Impala 2.8 First cut at 'new features' topic. Includes the Incompatible Changes

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-02-03 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 7: (10 comments) Addressed all comments. Dealt with some gerrit glitches (had to squash 2 commits that

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5795 To unsubscribe, visit

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: [DOCS] Genericize HBase page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5900/1/docs/topics/impala_hbase.xml File

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 3: rebase + fix 1 typo -- To view, visit http://gerrit.cloudera.org:8080/5795 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Michael Brown (Code Review)
Hello David Knupp, Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5795 to look at the new patch set (#3). Change subject: IMPALA-4359: qgen: add UPSERT support ..

[Impala-ASF-CR] [DOCS] Genericize HBase page

2017-02-03 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5900 Change subject: [DOCS] Genericize HBase page .. [DOCS] Genericize HBase page 2x links that point to archive.cloudera.com mirror of HBase

[Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support

2017-02-03 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4359: qgen: add UPSERT support .. Patch Set 2: Code-Review+2 (1 comment) Looks good to me.

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode This patch

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5494/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode .. IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode This patch

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 24: Build started:

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 24: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Clarify synchronization policy for 'done ' in KuduScanNode

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Clarify synchronization policy for 'done_' in KuduScanNode .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5494/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Yes, looking at it now. -- To view, visit

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. Change subject: Removed dead join inversion code from Analyzer. .. Abandoned As discussed with Alex, I'm abandoning this change and will submit a new change with a larger

[Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-3785: Record query handle for invalid handle .. IMPALA-3785: Record query handle for invalid handle Add the query handle to error messages for Invalid Query

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/234/ -- To view, visit

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5889 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-4822: Implement dynamic log level changes .. IMPALA-4822: Implement dynamic log level changes Very often we have to change the logging levels of

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 5: (9 comments) webserver-test.cc seems to be more unit-testing the WebServer class and I

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5889 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5889/1/be/src/exprs/expr.cc File be/src/exprs/expr.cc:

[Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4810: Add DECIMAL_V2 query option .. IMPALA-4810: Add DECIMAL_V2 query option This query option is going to be used to change both rounding semantics and

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#14). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs ..

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 15: (6 comments)

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5840/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Dimitris, can you please take a quick pass again to see if

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: Ping. Is this review thread still active ? -- To view, visit http://gerrit.cloudera.org:8080/5809

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-03 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 6: (1 comment) After pre-loading the data (lost the first few lines, can't figure out how to get more scrollback

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 8: Code-Review+2 Carry +2 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-02-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5811/5//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5732 to look at the new patch set (#7). Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5840/1/be/src/exec/kudu-scanner.cc

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5811/5//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded

2017-02-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5877/4//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded

2017-02-03 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded .. Patch Set 4: Upstream jenkins pre-review build is running:

[Impala-ASF-CR] IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded

2017-02-03 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5877 Change subject: IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded .. IMPALA-4839: Remote Kudu tests failing because

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 6: Code-Review+2 (8 comments) Thanks, that's easier to follow. Just some more

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5732 to look at the new patch set (#6). Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

[Impala-ASF-CR] IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen

2017-02-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen .. Patch Set 5: (5 comments)