[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: > Maybe the associated JIRA is a better place to have this > discussion, but I am trying to

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: Maybe the associated JIRA is a better place to have this discussion, but I am trying to

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Build failed due to what looks like problems with the Ubuntu package mirrors hosted

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/782/

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/7232/4//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#4). Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. IMPALA-5240: Allow config of number of disk I/O threads per disk type Currently Impala

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (2 comments) The overall approach makes sense to me. Happy to talk about the

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (4 comments) I think the interface changes make sense. I'm not digging into the code details

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5483: Automatically disable codegen for small queries .. IMPALA-5483: Automatically disable codegen for small queries This is similar to the single-node

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7268 Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem:

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6527 to look at the new patch set (#7). Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 7: Code-Review+1 Keep Tim's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#4). Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. IMPALA-5240: Allow config of number of disk I/O threads per disk type Currently Impala

[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 2: Code-Review+2 (3 comments) Much better, thanks.

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6778 To

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. IMPALA-4866: Hash join node does not apply limits correctly Hash join node

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. Patch Set 1: (2 comments) I haven't looked much at the Planner changes needed, eg. in

[Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7267 Change subject: DRAFT - IMPALA-5498: Support for partial sorts .. DRAFT - IMPALA-5498: Support for partial sorts Impala

[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes

2017-06-22 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes Cf. IMPALA-3807

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: PS 10 is a rebase and commit message update -- To view, visit

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/781/

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Code-Review+2 On second thought, I am confident to +2 this. -- To view, visit

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7264 To

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7264 to look at the new patch set (#2). Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. ..

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6778 To

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7264 To unsubscribe,

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: (1 comment) Thank you for fixing this so quickly!

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER COLUMN statement. Kudu recently added the ability to alter a column's

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6955 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7264 Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. IMPALA-5562: Only recomputeMemLayout() if tuple has a

[Impala-ASF-CR] IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails

2017-06-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/780/

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 5: Rebased. Also, corrected the result of related query in nested-types-subplan.test. --

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-22 Thread anujphadke (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6778 to look at the new patch set (#5). Change subject: IMPALA-4866: Hash join node does not apply limits correctly

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7203/3/be/src/runtime/runtime-state.h File

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-22 Thread Bikramjeet Vig (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7203 to look at the new patch set (#4). Change subject: IMPALA-3504: UDF for current timestamp in UTC .. IMPALA-3504:

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/779/ -- To view, visit

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 10: Code-Review+2 Rebased, carrying forward -- To view, visit

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-22 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. Patch Set 2: Added default option as None.

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-22 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. IMPALA-2782: Allow impala-shell to connect

[Impala-ASF-CR] IMPALA-5553: Fix expr-test in release builds

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5553: Fix expr-test in release builds .. IMPALA-5553: Fix expr-test in release builds expr-test fails in release build as it uses

[Impala-ASF-CR] IMPALA-5553: Fix expr-test in release builds

2017-06-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5553: Fix expr-test in release builds .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7255 To unsubscribe, visit