Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 7:
(10 comments)
Looks pretty close to me.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7591
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
IMPALA-5666: ASAN poisoning for MemPool and BufferPool
* Use
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 2:
(1 comment)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using TLS / Thrift
The 'cipher suite' is a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7591/1//COMMIT_MSG
Commit Message:
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
IMPALA-4669: [KUTIL] Add kudu_util library to the build.
A few miscellaneous changes to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py
..
Patch Set 1:
Does the toolchain version need to be bumped as well?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream
..
Patch Set 1:
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py
..
Patch Set 1: Code-Review+2
No, if it's already in the current toolchain version you don't need a separate
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7624
Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests
..
IMPALA-5781: Only use TLSv1.0-compatible ciphers for
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 1:
(1 comment)
Quick question before I get stuck in - did you evaluate
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Any takers for a review? This patch reduces the be-test end-to-end time from
Henry Robinson has uploaded a new patch set (#2).
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
(PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
Googletest supports sharded
Henry Robinson has uploaded a new patch set (#12).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Set toolchain version
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 12:
This patch builds on RHEL5.5 and 6.0, debian 7 and 8, ubuntu 12.04 and 14.04,
and
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7492
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7606
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
IMPALA-5743: Support TLS version configuration
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7608
Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string
..
IMPALA-5774: Prevent FindInSet() from reading off
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Only in the sense that I was hoping for some feedback on the approach (e.g. is
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 6: Code-Review+2
Forgot to add the couple of lines of code to enable this in the
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7542
To
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7524
to look at the new patch set (#6).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
My instinct would be just to use the size of tasks_ to control the coordination.
In
Henry Robinson has posted comments on this change.
Change subject: IMPALA-1891: Statestore won't send deletions in initial
non-delta topic
..
Patch Set 1: Code-Review+2
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7524
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7524
to look at the new patch set (#5).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7600
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 5: Code-Review+2
Fix some clang-tidy warnings in the tests.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 2: Code-Review+2
(3 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
(4 comments)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a 'backends' tab to query details pages
Henry Robinson has abandoned this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7712
To unsubscribe, visit
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7711
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
Presumably the query was a DDL statement, so there was no coordinator. Thanks
for the
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Thanks for the review, btw - I'm working on some ergonomic improvements before
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
IMPALA-4786: Clean up how ImpalaServers are created
ImpalaServer had to be created via an awkward
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(5 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 2:
That's deliberate - preserve the last seen set of states. I could change
something to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7712/1//COMMIT_MSG
Commit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import Squeasel as of
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
FWIW (and this is veering away from an Apache discussion), I thought
Henry Robinson has uploaded a new patch set (#12).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 12:
This patch builds on all platforms we test on here at Cloudera.
--
To view, visit
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7732
Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in
test_client_ssl.py
..
IMPALA-5775: (Addendum) Make SSL
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#14).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7709
To
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7752
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
..
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
..
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The previous commit for IMPALA-5800 imported a
Henry Robinson has posted comments on this change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7705
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6707/3/www/query_plan.tmpl
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 10:
Thanks for the review, Tim - do you have any further comments?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6889
Change subject: IMPALA-5174: Bump gflags to 2.2.0-p1
..
IMPALA-5174: Bump gflags to 2.2.0-p1
This gflags patch adds
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"
..
Patch Set 1:
If hdfsGetLastExceptionRootCause() always contains relevant information, I
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
Patch Set 2: Verified+1
Passed a full toolchain build.
--
To view, visit
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
See
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7142
Change subject: IMPALA-5480: Improve missing filters message
..
IMPALA-5480: Improve missing filters message
Replace:
"Only following
Henry Robinson has abandoned this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Abandoned
Superseded by https://gerrit.cloudera.org/#/c/7103/
--
To view, visit
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the data-flow parts of ImpalaInternalService to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7103/1/be/src/runtime/data-stream-mgr.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
..
Patch Set 5: Code-Review+1
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7238
Change subject: Bump thrift toolchain version to 0.9.0-p9
..
Bump thrift toolchain version to 0.9.0-p9
The toolchain has already been
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7228
Change subject: IMPALA-1474: Add a metric for running queries
..
IMPALA-1474: Add a metric for running queries
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7224/1/source/krb5/build.sh
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
IMPALA-5526: Add krb5 1.15.1 to toolchain
Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655
---
M
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7224
To unsubscribe, visit
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7224
to look at the new patch set (#2).
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
IMPALA-5526: Add
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
Patch Set 2:
Carry +2. This already passed a full toolchain build.
--
To view, visit
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7224
Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain
..
IMPALA-5526: Add krb5 1.15.1 to toolchain
Change-Id:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
..
Patch Set 2:
(6 comments)
looks good. I'll have another think about it. Could you ask
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Patch Set 3: Code-Review+2
Carry +2, rebase.
--
To view, visit
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the data-flow parts of ImpalaInternalService to
Henry Robinson has uploaded a new patch set (#14).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 5:
(22 comments)
PS4 is a rebase. PS5 includes the review responses (so diff 4->5 if you want to
Henry Robinson has uploaded a new patch set (#15).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
This patch
Henry Robinson has uploaded a new patch set (#9).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Set toolchain version to
Henry Robinson has uploaded a new patch set (#5).
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the data-flow parts of ImpalaInternalService to
Henry Robinson has uploaded a new patch set (#10).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Set toolchain version
Henry Robinson has uploaded a new patch set (#10).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6473
to look at the new patch set (#8).
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#19).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 10:
Michael - this includes the KRB5 and OpenSSL linking fixes.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 5:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 5:
(1 comment)
Henry Robinson has abandoned this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Abandoned
Bad merge - will restore when I fix it.
--
To view, visit
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#5).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 6:
Thanks - I'm in the middle of that :)
--
To view, visit http://gerrit.cloudera.org:8080/7206
To
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7206
to look at the new patch set (#7).
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
IMPALA-5481:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL
connection
..
Patch Set 1:
(1 comment)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7226
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
IMPALA-5532: Stack-allocate compressors in
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 7: Code-Review+1
Rebase, carry +1.
--
To view, visit http://gerrit.cloudera.org:8080/7206
To
Hello Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#2).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Patch Set 1:
(6 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5536: Fix TCLIService thrift compilation on Hive 2
..
Patch Set 2:
(1 comment)
Joe - is this rebased on the Sentry version revert patch? If not, I
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Patch Set 4:
I fixed the placement of WARN_UNUSED_RESULT in the previous patchset,
601 - 700 of 874 matches
Mail list logo
