Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: variable-length scratch file ranges
..
Patch Set 6: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/5597
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4676: remove vestigial references to
getBlockStorageLocations() API
..
Patch Set 4:
Looks like the job failure was an infrastructure failure talking to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 1:
(15 comments)
I think the overall approach makes sense. I had some higher-level
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc
File
Tim Armstrong has posted comments on this change.
Change subject: Add disclaimer to docs: Cloudera-specific info still present.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5610
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5401
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc
File
Tim Armstrong has uploaded a new patch set (#8).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5633
Change subject: IMPALA-4676: remove the last reference to BlockStorageLocation
..
IMPALA-4676: remove the last reference to
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-4617: remove IsConstant() analysis from be
..
IMPALA-4617: remove IsConstant() analysis from be
This change avoids the need to duplicate the logic in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4617: remove IsConstant() analysis from be
..
Patch Set 5:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 2:
Carry the +1
--
To view, visit http://gerrit.cloudera.org:8080/5615
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 3: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 3:
(13 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5635
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads
..
Patch Set 1:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 23:
(1 comment)
Fixed a couple of bugs that I discovered when building things on top of this.
Tim Armstrong has uploaded a new patch set (#24).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
I'm ok with this change but I think we should add the logging in case we hit
the problem on
Tim Armstrong has uploaded a new patch set (#25).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 24:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5141/24//COMMIT_MSG
Commit Message:
PS24,
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5597
to look at the new patch set (#5).
Change subject: IMPALA-3202: variable-length scratch file ranges
..
IMPALA-3202:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4676: remove vestigial references to
getBlockStorageLocations() API
..
Patch Set 4: Code-Review+2
Rebase
--
To view, visit
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5141
to look at the new patch set (#28).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 28: Code-Review+2
Needed to update test_set to reflect the changed default value of max_errors.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: variable-length scratch file ranges
..
Patch Set 5: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5597
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4689: Fix computation of last active time
..
Patch Set 2: Code-Review+2
(1 comment)
Test changes look code aside from one minor comment.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext
..
Patch Set 2:
I do think we need three classes here (the documentation and maybe naming could
Tim Armstrong has uploaded a new patch set (#8).
Change subject: IMPALA-4617: remove IsConstant() analysis from be
..
IMPALA-4617: remove IsConstant() analysis from be
This change avoids the need to duplicate the logic in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 27: Code-Review+2
Carry Dan's +2
--
To view, visit http://gerrit.cloudera.org:8080/5141
To
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5141
to look at the new patch set (#26).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP IF EXISTS.
..
Patch Set 3:
This is a long shot, but could IMPALA-4612 be related to this?
--
To view, visit
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3202: variable-length scratch file ranges
..
IMPALA-3202: variable-length scratch file ranges
This uses a simple approach where scratch ranges are managed
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 23:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5141/23/be/src/runtime/tmp-file-mgr.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Avoid updating Expr's states from ExprContext
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4653: fix sticky config variable problem
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5545/2/bin/impala-config-branch.sh
File
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5545
to look at the new patch set (#3).
Change subject: IMPALA-4653: fix sticky config variable problem
..
IMPALA-4653:
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
IMPALA-3202: implement spill-to-disk in new buffer pool
See https://goo.gl/0zuy97 for a high-level
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4742: Change "{}".format() to "{0}".format() for Py 2.6
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5641
To
Hello Jim Apple, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5615
to look at the new patch set (#2).
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py
File
Hello Marcel Kornacker, Impala Public Jenkins, Jim Apple, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5615
to look at the new patch set (#3).
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 3: Code-Review+2
(1 comment)
Carry +2
Hello Marcel Kornacker, Impala Public Jenkins, Jim Apple, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5615
to look at the new patch set (#4).
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
Tim Armstrong has posted comments on this change.
Change subject: Set version of CDH dependencies to cdh5.11.0-SNAPSHOT.
..
Patch Set 3:
It sort of looks like it ran against Impala-lzo without this commit:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4684: Wrap checking for HBase nodes ina try/finally
block
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5547
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 16:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5141/16/be/src/runtime/buffered-block-mgr.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4707: Fix command line help for
webserver_private_key_file
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5552/1//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4702: Fix command line help for
webserver_private_key_file
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5552
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4014: Introduce query-wide execution state.
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4418/14/be/src/runtime/query-exec-mgr.cc
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5558
Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
..
IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
Re-tested to
Tim Armstrong has uploaded a new patch set (#20).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 17:
(22 comments)
Tim Armstrong has uploaded a new patch set (#17).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 20:
(25 comments)
Added an end-to-end test. This required adding a flag to allow multiple scratch
Tim Armstrong has uploaded a new patch set (#21).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 14:
Thanks for your contribution! Please go ahead and resolve the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4710: There is an error in control audit log file size
number
..
Patch Set 1: Code-Review+2
Nice catch
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4710: There is an error in control audit log file size
number
..
Patch Set 2: Code-Review+2
Rebased onto master
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 12: Code-Review+2
This seems like it should be uncontroversial,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 13: Code-Review+2
Needed a rebase
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow
..
Patch Set 11:
(2 comments)
Looks good - couple of minor comments
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
..
Patch Set 1: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/5558
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4684: Handle unexpected exceptions while checking for
HBase nodes
..
Patch Set 1:
(1 comment)
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5545
to look at the new patch set (#2).
Change subject: IMPALA-4653: fix sticky config variable problem
..
IMPALA-4653:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 3:
(10 comments)
Looking pretty good
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 16:
(33 comments)
http://gerrit.cloudera.org:8080/#/c/5141/16/be/src/runtime/disk-io-mgr.h
File
Tim Armstrong has uploaded a new patch set (#18).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 16:
Did the temp->scratch rename in PS18
--
To view, visit http://gerrit.cloudera.org:8080/5141
Tim Armstrong has uploaded a new patch set (#19).
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
IMPALA-3202,IMPALA-2079: rework scratch file I/O
Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O
..
Patch Set 19:
Reverted to PS17. Will do the rename in a follow-on patch.
--
To view, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5569
Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next2
..
Merge remote-tracking branch 'origin/master' into
Tim Armstrong has posted comments on this change.
Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next
..
Patch Set 2: Code-Review+2 Verified+1
Just merging a few commits from master
--
To view,
Tim Armstrong has submitted this change and it was merged.
Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next
..
Merge remote-tracking branch 'origin/master' into hadoop-next
Change-Id:
Tim Armstrong has uploaded a new patch set (#2).
Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next
..
Merge remote-tracking branch 'origin/master' into hadoop-next
Change-Id:
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
..
IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
Re-tested to make sure that
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5558
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5558
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4595: Ignore discarded functions after linking
..
Patch Set 1:
(1 comment)
Code change looks good
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4539: fix bug when scratch batch references I/O buffers
..
Patch Set 4: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/5406
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4539: fix bug when scratch batch references I/O buffers
..
Patch Set 3:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Elide Cloudera URLs for UDFs
..
Patch Set 1: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Patch Set 4:
(2 comments)
Looks like this accidentally reverted some deliberate changes we made.
Tim Armstrong has posted comments on this change.
Change subject: Pass build type to Impala LZO.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz
compressed symbols
..
Patch Set 1:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..
Patch Set 1:
(3 comments)
Change looks ok to me, just some minor comments on the interface
Tim Armstrong has uploaded a new patch set (#6).
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
PREVIEW: IMPALA-4678: port backend exec to use buffer pool
Always create global BufferPool at
Tim Armstrong has posted comments on this change.
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
Patch Set 6:
Fixed some unnecessary formatting changes and artefacts of the previous rebase.
--
Tim Armstrong has uploaded a new patch set (#10).
Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool
..
IMPALA-3203: Part 2: per-core free lists in buffer pool
Add per-core lists of clean pages and free
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6469
Change subject: IMPALA-5113: fix dirty unpinned invariant
..
IMPALA-5113: fix dirty unpinned invariant
There were two bugs:
* The
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4226, IMPALA-4227: bump max threads, handle dwz
compressed symbols
..
Patch Set 1:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5113: fix dirty unpinned invariant
..
Patch Set 1:
I discussed offline with Dan and agreed we should rephrase the invariant so
that it's more along the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch
space
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5523
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior: left shift of negative
values
..
Patch Set 1:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe,
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6493
Change subject: IMPALA-4701: make distcc work reliably with clang
..
IMPALA-4701: make distcc work reliably with clang
The previous
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-5113: fix dirty unpinned invariant
..
IMPALA-5113: fix dirty unpinned invariant
There were two bugs:
* The invariant was too strict and didn't take into
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5113: fix dirty unpinned invariant
..
Patch Set 4:
(8 comments)
801 - 900 of 2851 matches
Mail list logo
