[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-31 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 18: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-20 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-06 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc File be/s

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-05 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7063/3/be/src/rpc/thrift-util.cc File be/

[Impala-ASF-CR] IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC

2017-01-23 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5720/2/be/src/statestore/s

[Impala-ASF-CR] IMPALA-4383: Ensure plan fragment report thread is always started

2016-10-27 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4383: Ensure plan fragment report thread is always started .. Patch Set 1: I agree with the fix. but just want to clarify the impact. I checked this piece of

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-17 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. Patch Set 2: Code-Review+2 (1 comment) Carry Dan's +2 http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-17 Thread Juan Yu (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4668 to look at the new patch set (#2). Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-07 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new change for review. http://gerrit.cloudera.org:8080/4668 Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. IMPALA-4253: impala-server.backends.cli

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4519/3/be/src/rpc/TAccept

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/exec/hdfs-scan-node.cc File be

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-27 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4519/1/be/src/server/TAcce

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-27 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (2 comments) code style, we use 4 space indent for continued line http://

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4500 To unsub

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/src/rpc/r

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: What's the performance of updating this metrics? -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File be/src/rpc/

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statestore/stat

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statestore/stat

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

2016-09-15 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 5: Code-Review+2 Rebased, carry Henry's +2 -- To view, visit http://gerrit.cloudera.org:8080/4080 To unsu