Internal Jenkins has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4877
To unsubscribe,
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
IMPALA-1286: Extract common conjuncts from disjunctions.
Adds a new ExprRewriteRule to
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 7: Code-Review+2
Trivial update in expected plan to an equivalent one.
--
To view, visit
Hello Marcel Kornacker, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4877
to look at the new patch set (#7).
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 6: Verified-1
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 6:
I think there would have to be some distinction between logical types and
physical
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4877
To unsubscribe, visit
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 5:
Thanks for the explanation and your patience. I'm certainly open to learning
more about a
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 5:
I don't agree with the argument that the new behavior with constant folding
will be less
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 5:
I understand that it's harmless in that queries that succeeded before the patch
won't
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 4:
I added a new query option ENABLE_EXPR_REWRITES and set it to false for
expr-test.cc
I
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4877
to look at the new patch set (#5).
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc
File
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc
File
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 3:
(1 comment)
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4877
to look at the new patch set (#3).
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 2:
(7 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(1 comment)
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(2 comments)
Alex Behm has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(11 comments)
Still working on a minor test fix, sending out to continue CR.
Alex Behm has restored this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Restored
--
To view, visit http://gerrit.cloudera.org:8080/4877
To unsubscribe, visit
Alex Behm has abandoned this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Abandoned
Putting this on hold for now.
--
To view, visit http://gerrit.cloudera.org:8080/4877
To unsubscribe,
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(3 comments)
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.
..
Patch Set 1:
(6 comments)
25 matches
Mail list logo