[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe,

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. IMPALA-1286: Extract common conjuncts from disjunctions. Adds a new ExprRewriteRule to

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 7: Code-Review+2 Trivial update in expected plan to an equivalent one. -- To view, visit

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4877 to look at the new patch set (#7). Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 6: I think there would have to be some distinction between logical types and physical

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 5: Thanks for the explanation and your patience. I'm certainly open to learning more about a

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 5: I don't agree with the argument that the new behavior with constant folding will be less

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 5: I understand that it's harmless in that queries that succeeded before the patch won't

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 4: I added a new query option ENABLE_EXPR_REWRITES and set it to false for expr-test.cc I

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-07 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4877 to look at the new patch set (#5). Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4877 to look at the new patch set (#3). Change subject: IMPALA-1286: Extract common conjuncts from disjunctions.

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-02 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (11 comments) Still working on a minor test fix, sending out to continue CR.

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-11-01 Thread Alex Behm (Code Review)
Alex Behm has restored this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Restored -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Abandoned Putting this on hold for now. -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe,

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-28 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Patch Set 1: (6 comments)