[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 16: (1 comment) After fighting the compiler for over an hour to figure out why our operator<< was not

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/16//COMMIT_MSG Commit Message: Line 64:

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) I am trying to get the DCHECK_EQ to work with int128_t, for which we do provide a

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#16). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG Commit Message: Line 122 >

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG Commit Message: Line 122: do to

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/5951/15/be/src/benchmarks/expr-benchmark.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#15). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: (5 comments) > I have not updated the Python test yet, as that would require a > rebase. Python test

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: I have not updated the Python test yet, as that would require a rebase. Python test and benchmark

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/decimal-operators-ir.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc File

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both