Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
IMPALA-2615: support [[nodiscard]] on Status
This is the set of changes required to get Impala
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 15:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1084/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 15: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14: Code-Review+2
(1 comment)
Seems okay to me, though maybe we could improve the name of
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
It would be good if someone could take a quick look at the PS13->14 delta to
make sure that the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1073/
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 14:
There were some side-effects of changing the startup order. Updated with a less
invasive solution
Hello Impala Public Jenkins, Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7253
to look at the new patch set (#14).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1073/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13:
expr-test failed for a different reason this time that needs investigation.
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1071/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1071/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 13: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 12: Code-Review+2
The bug is that the in-process servers start the statestore subscriber before
Hello Impala Public Jenkins, Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7253
to look at the new patch set (#12).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1068/
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 11: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1068/
--
To view,
Hello Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7253
to look at the new patch set (#11).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Hello Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7253
to look at the new patch set (#10).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 10: Code-Review+2
(1 comment)
Rebase
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9:
Yeah we could drop it for Status return values. We would keep it for bool or
other return values
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9: Code-Review+2
(1 comment)
So once nodiscard is supported everywhere, would we drop the
Jim Apple has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt
File be/CMakeLists.txt:
Tim Armstrong has uploaded a new patch set (#8).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
IMPALA-2615: support [[nodiscard]] on Status
This is the set of changes required to get Impala to compile on
GCC 7
Jim Apple has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt
File be/CMakeLists.txt:
Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 6:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7253/5/be/CMakeLists.txt
File be/CMakeLists.txt:
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
IMPALA-2615: support [[nodiscard]] on Status
This is the set of changes required to get Impala to compile on
GCC 7
35 matches
Mail list logo
