[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8d

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/954/ -- To view, visi

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Hit another flaky test :( - Trying again. -- To view, visit http://gerrit.cloudera.org:8080/4554

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/953/ -- To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/953/ -- To view, visi

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Code-Review+2 Rebased the change after hitting the same Kudu issue again. Carrying Tim's +2. -- T

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/942/ -- To view, visit

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/942/ -- To view, visi

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Restarting GVO, previous one seems to have hit IMPALA-5733. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/939/ -- To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/939/ -- To view, visi

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: (3 comments) PS6 rebases PS5. PS7 addresses Tim's comments. http://gerrit.cloudera.org:8080/#/c/4

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4554 to look at the new patch set (#7). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086:

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-26 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4554 to look at the new patch set (#6). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086:

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: There's no rush, we can leave it open, just wanted to clarify what the state of it was. -- To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: > Did this get lost in the shuffle? I'm trying to pare down my review > inbox a bit :) It's still

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Did this get lost in the shuffle? I'm trying to pare down my review inbox a bit :) -- To view,

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Code-Review+2 Trying to refresh my memory but looks like we're ok to go forward once the comment

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-06-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Tim, please do the +2 on this one once Lars response to your last comments and you're happy with the

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Code-Review+1 Should have +1ed earlier since I only had minor suggestions -- To view, visit htt

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: (3 comments) This is still just benchmarking ComputeScanRangeAssignment(), right, not the whole

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: I updated the TODO in scheduler.h and renamed the scheduler benchmark cc file. -- To view, visit

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M be/src/

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-03 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 4: We should update/remove this TODO - https://github.com/apache/incubator-impala/blob/master/be/src/s

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 4: PS4: rebased PS3 -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-04-01 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M be/src/

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 3: PS3 is rebase only. Still needs changes to work on top of Schedule() instead of ComputeScanRangeAs

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M be/src/

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e --- M be/src/

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: (3 comments) Thanks Tim for the review. I addressed your comments in PS2. I will rebase this next

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: Marcel asked me to rebase this onto his MT-related changes to the scheduler and rework the benchma

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: Lars, are you still working on this? Anything blocking from making progress on the review? -- To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4554/1/be/src/benchmarks/simple-scheduler-bench

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-09-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4554 Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id: I89ec1c6c182