[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe,

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1218/ -- To

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (2 comments) Changed to INTERNAL_ERROR for the possible error in GetNextBuffer().

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#12). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 11: Code-Review+1 The stricter invariant makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc File

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#11). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/10/be/src/exec/scanner-context.cc File

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 10: I fixed more test errors and will run an exhaustive build in parallel now. -- To view,

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8011 to look at the new patch set (#10). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ..

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#9). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/8/be/src/exec/base-sequence-scanner.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/8/be/src/exec/base-sequence-scanner.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-12 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#8). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#7). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/base-sequence-scanner.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: > Yeah we could probably add an error code like DISK_IO_MGR_ERROR and > use it for the

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: Yeah we could probably add an error code like DISK_IO_MGR_ERROR and use it for the

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/scanner-context.h File

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/scanner-context.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/5/be/src/exec/base-sequence-scanner.cc

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/8011/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/8011/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. Patch Set 3: Rebased -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5890: Abort queries if scanner hits IO errors

2017-09-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5890: Abort queries if scanner hits IO errors .. IMPALA-5890: Abort queries if scanner hits IO errors Prior to this fix, an error in