[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 6: (18 comments) http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt File LICENSE.txt: PS6, Line 512:

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-28 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#7). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-28 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#3). Change subject: [tools] Manual recovery tools (part 1)

[kudu-CR] Enable GSSAPI for servers and ExternalMiniCluster

2016-10-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Enable GSSAPI for servers and ExternalMiniCluster .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/4765/10/src/kudu/security/mini_kdc.cc File

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 7: (17 comments)

[kudu-CR] KUDU-100 make RLE encoder handle 64-bit integer.

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-100 make RLE encoder handle 64-bit integer. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4822 To unsubscribe, visit

[kudu-CR] KUDU-100 make RLE encoder handle 64-bit integer.

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-100 make RLE encoder handle 64-bit integer. .. KUDU-100 make RLE encoder handle 64-bit integer. Fix edge cases in bit stream. Change-Id:

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 6: btw, you can edit build-support/lint.sh to exclude the x509_check_host.cc file from lint checking. -- To view,

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 6: (16 comments) http://gerrit.cloudera.org:8080/#/c/4789/6/LICENSE.txt File LICENSE.txt: PS6, Line 512:

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix SASL mechanism negotiation on the server side .. Fix SASL mechanism negotiation on the server side This fixes the order in which the SASL server is

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove unused code for checking PLAIN authentication .. Remove unused code for checking PLAIN authentication This removes the 'AuthStore' abstraction

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Remove unused code for checking PLAIN authentication .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4874 To unsubscribe, visit

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix SASL mechanism negotiation on the server side .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4875 To unsubscribe, visit

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4875 to look at the new patch set (#4). Change subject: Fix SASL mechanism negotiation on the server side .. Fix SASL

[kudu-CR] WIP: Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Fix SASL mechanism negotiation on the server side .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4875/1/src/kudu/rpc/sasl_rpc-test.cc

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#4). Change subject: [java client] Implement RPC tracing, part 1 .. [java client]

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4871 To

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-10-28 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-10-28 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4795 to look at the new patch set (#4). Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions ..

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Remove unused code for checking PLAIN authentication .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4874/2/src/kudu/rpc/rpc-test-base.h File

[kudu-CR] rpc: support GSSAPI authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: support GSSAPI authentication .. rpc: support GSSAPI authentication This patch consists of a bunch of changes necessary to support GSSAPI (Kerberos)

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: improve error messages and logging for bad authentication .. rpc: improve error messages and logging for bad authentication * Don't dump the trace

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication .. Patch Set 6: Code-Review+2 Just rebased -- To view, visit http://gerrit.cloudera.org:8080/4764

[kudu-CR] rpc: support GSSAPI authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 6: Code-Review+2 Just rebased -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (1 comment)

[kudu-CR] rpc: support GSSAPI authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4763 to look at the new patch set (#6). Change subject: rpc: support GSSAPI authentication .. rpc:

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4874 to look at the new patch set (#2). Change subject: Remove unused code for checking PLAIN authentication .. Remove

[kudu-CR] WIP: Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4875 to look at the new patch set (#2). Change subject: WIP: Fix SASL mechanism negotiation on the server side .. WIP:

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix SASL mechanism negotiation on the server side .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4875/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove unused code for checking PLAIN authentication .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4874/1/src/kudu/rpc/rpc-test-base.h File

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-10-28 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4823 to look at the new patch set (#3). Change subject: KUDU-1638 - [python] Add Alter Table Support .. KUDU-1638 -

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (16 comments) > Would be nice to understand whether there's a perf impact to this, > to

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

2016-10-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1611 - [python] Enable setting scanner selection policy .. KUDU-1611 - [python] Enable setting scanner selection policy Currently the python

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. KUDU-1680 - [python] Improve PartialRow Usability The current semantics for setting values in a

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4760 To unsubscribe, visit

[kudu-CR] KUDU-100 make RLE encoder handle 64-bit integer.

2016-10-28 Thread Haijie Hong (Code Review)
Haijie Hong has posted comments on this change. Change subject: KUDU-100 make RLE encoder handle 64-bit integer. .. Patch Set 2: > (6 comments) > > Are you planning on another patch which will enable the ability to > use

[kudu-CR] KUDU-100 make RLE encoder handle 64-bit integer.

2016-10-28 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4822 to look at the new patch set (#2). Change subject: KUDU-100 make RLE encoder handle 64-bit integer. .. KUDU-100

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#6). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 5: (2 comments) Should I convert all the C-style casts in the ported code to C++ style casts?

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (34 comments) http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc File

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-28 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#5). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with