[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2037 fix flake in ts_recovery-itest .. Patch Set 3: Code-Review+2 thanks for the investigation -- To view, visit http://gerrit.cloudera.org:8080/7138 To

[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2037 fix flake in ts_recovery-itest .. KUDU-2037 fix flake in ts_recovery-itest Fixed flake in TsRecoveryITest.TestRestartWithOrphanedReplicates

[kudu-CR] fs manager: clean tmp files from all special directories

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs_manager: clean tmp files from all special directories .. Patch Set 1: Code-Review+2 lgtm, did you verify this? -- To view, visit

[kudu-CR] Fix misc-move-const-arg tidy warnings

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix misc-move-const-arg tidy warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7133/1/src/kudu/benchmarks/tpch/tpch_real_world.cc File

[kudu-CR] fs manager: clean tmp files from all special directories

2017-06-09 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7144 to review the following change. Change subject: fs_manager: clean tmp files from all special directories ..

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1442 log number of open log block containers .. KUDU-1442 log number of open log block containers Tservers with large numbers of log block containers

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 6: Verified+1 Overriding Jenkins, one of the Java or Python tests left behind a minidump. Unrelated

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7111 To unsubscribe, visit

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Sam Okrent (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7111 to look at the new patch set (#6). Change subject: KUDU-1442 log number of open log block containers ..

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7111/5//COMMIT_MSG Commit Message: Line 26:

[kudu-CR] Fix misc-move-const-arg tidy warnings

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix misc-move-const-arg tidy warnings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7133/1/src/kudu/benchmarks/tpch/tpch_real_world.cc File

[kudu-CR] Fix misc-string-* clang-tidy warnings

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix misc-string-* clang-tidy warnings .. Fix misc-string-* clang-tidy warnings Change-Id: I7f2dcb07813c1e3ba15e60f1f3b688d5b1e41c4f Reviewed-on:

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Use the same replica selection when adding a server as table creation .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Sam Okrent (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7111 to look at the new patch set (#5). Change subject: KUDU-1442 log number of open log block containers ..

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Use the same replica selection when adding a server as table creation .. Patch Set 1: (1 comment)

[kudu-CR] Use the same replica selection when adding a server as table creation

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7143 Change subject: Use the same replica selection when adding a server as table creation .. Use the same replica selection when adding a

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#3). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [tools] Rename `kudu test` to `kudu perf` .. [tools] Rename `kudu test` to `kudu perf` This renames the `kudu test` action to `kudu perf`, for the

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Rename `kudu test` to `kudu perf` .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7117 To unsubscribe, visit

[kudu-CR] [webui] Fix placement of tombstone tablet blurb

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [webui] Fix placement of tombstone tablet blurb .. [webui] Fix placement of tombstone tablet blurb In b492d8ed3c, some text explaining what a

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#2). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] Rename `kudu test` to `kudu perf` .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7117 To unsubscribe, visit

[kudu-CR] [webui] Fix placement of tombstone tablet blurb

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [webui] Fix placement of tombstone tablet blurb .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7136 To unsubscribe, visit

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7111 To unsubscribe, visit

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7141 Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior in TlsSocket::Writev() TlsSocket::Writev() was

[kudu-CR] Fix misc-string-* clang-tidy warnings

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix misc-string-* clang-tidy warnings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7132 To unsubscribe, visit

[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix all 'misc-string-compare' warnings from clang-tidy .. Patch Set 2: Code-Review+2 forwarding +2 -- To view, visit http://gerrit.cloudera.org:8080/7131 To

[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Tweak build-and-test.sh to fix spark1 test failures .. Tweak build-and-test.sh to fix spark1 test failures Maven seems to be caching old artifacts which

[kudu-CR] Enable move constructors for protobufs

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Enable move constructors for protobufs .. Enable move constructors for protobufs This enables an experimental option for protobuf to generate move

[kudu-CR] Enable move constructors for protobufs

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Enable move constructors for protobufs .. Patch Set 6: Code-Review+2 forwarding +2 -- To view, visit http://gerrit.cloudera.org:8080/6900 To unsubscribe, visit

[kudu-CR] Fix all 'misc-string-compare' warnings from clang-tidy

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix all 'misc-string-compare' warnings from clang-tidy .. Fix all 'misc-string-compare' warnings from clang-tidy See

[kudu-CR] Fix various use-after-move errors

2017-06-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix various use-after-move errors .. Fix various use-after-move errors This fixes all of the cases where clang-tidy detects 'misc-use-after-move'. This

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7111/1/src/kudu/fs/log_block_manager.cc File

[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2037 fix flake in ts_recovery-itest .. Patch Set 3: Verified+1 The build failure is unrelated -- it is attributed to the 'dirty' state of the third-party

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7111/3//COMMIT_MSG Commit Message: Line 20:

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7111 to look at the new patch set (#4). Change subject: KUDU-1442 log number of open log block containers .. KUDU-1442

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] Rename `kudu test` to `kudu perf` .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7117 To unsubscribe, visit

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Rename `kudu test` to `kudu perf` .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7117 To unsubscribe, visit

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1442 log number of open log block containers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7111/3//COMMIT_MSG Commit Message: Line 20:

[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures

2017-06-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Tweak build-and-test.sh to fix spark1 test failures .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7129 To unsubscribe, visit

[kudu-CR] KUDU-1442 log number of open log block containers

2017-06-09 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7111 to look at the new patch set (#3). Change subject: KUDU-1442 log number of open log block containers .. KUDU-1442

[kudu-CR] Fix various use-after-move errors

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix various use-after-move errors .. Patch Set 3: Code-Review+2 sorry that was an unintentional rebase. I was trying to see whether rebasing over this patch

[kudu-CR] Fix various use-after-move errors

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix various use-after-move errors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7130 To unsubscribe, visit

[kudu-CR] Fix various use-after-move errors

2017-06-09 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7130 to look at the new patch set (#2). Change subject: Fix various use-after-move errors .. Fix various

[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7138 to look at the new patch set (#3). Change subject: KUDU-2037 fix flake in ts_recovery-itest .. KUDU-2037 fix flake

[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: KUDU-2037 fix flake in ts_recovery-itest .. KUDU-2037 fix flake in ts_recovery-itest Fixed flake in TsRecoveryITest.TestRestartWithOrphanedReplicates scenario.

[kudu-CR] KUDU-2037 fix flake in ts recovery-itest

2017-06-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7138 Change subject: KUDU-2037 fix flake in ts_recovery-itest .. KUDU-2037 fix flake in ts_recovery-itest Fixed flake in

[kudu-CR] [webui] Fix placement of tombstone tablet blurb

2017-06-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [webui] Fix placement of tombstone tablet blurb .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7136 To unsubscribe, visit

[kudu-CR] [webui] Fix placement of tombstone tablet blurb

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7136 Change subject: [webui] Fix placement of tombstone tablet blurb .. [webui] Fix placement of tombstone tablet blurb In b492d8ed3c, some

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [tools] Rename `kudu test` to `kudu perf` .. Patch Set 1: (1 comment) Sorry for the delay...build problems on OS X.

[kudu-CR] [tools] Rename `kudu test` to `kudu perf`

2017-06-09 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7117 to look at the new patch set (#2). Change subject: [tools] Rename `kudu test` to `kudu perf` .. [tools] Rename

[kudu-CR] Tweak build-and-test.sh to fix spark1 test failures

2017-06-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7129 to look at the new patch set (#2). Change subject: Tweak build-and-test.sh to fix spark1 test failures .. Tweak