[kudu-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-07-24 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7471 to look at the new patch set (#3). Change subject: KUDU-1865: Avoid heap allocation for payload slices ..

[kudu-CR] [WIP]log block manager: mark container as 'read only' after syncing error

2017-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP]log block manager: mark container as 'read_only' after syncing error .. Patch Set 10: (1 comment)

[kudu-CR] [WIP]log block manager: mark container as 'read only' after syncing error

2017-07-24 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#10). Change subject: [WIP]log block manager: mark container as 'read_only' after syncing error

[kudu-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-1865: Avoid heap allocation for payload slices .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7471/1/src/kudu/rpc/inbound_call.h File

[kudu-CR] Fix bug KUDU-2058

2017-07-24 Thread Anonymous Coward (Code Review)
srisaikum...@gmail.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7491 Change subject: Fix bug KUDU-2058 .. Fix bug KUDU-2058 Change-Id: Ic779aa9eb3587f79252a7dd9139d54e262a8a174 --- M

[kudu-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-07-24 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7471 to look at the new patch set (#2). Change subject: KUDU-1865: Avoid heap allocation for payload slices ..

[kudu-CR] [WIP]log block manager: mark container as 'read only' after syncing error

2017-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [WIP]log block manager: mark container as 'read_only' after syncing error .. Patch Set 9: (11 comments)

[kudu-CR] [WIP]log block manager: mark container as 'read only' after syncing error

2017-07-24 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7374 to look at the new patch set (#9). Change subject: [WIP]log block manager: mark container as 'read_only' after syncing error

[kudu-CR] disk failure: coordinate error handling

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#23). Change subject: disk failure: coordinate error handling .. disk failure:

[kudu-CR] WIP disk failure: forced shutdown of replicas

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#5). Change subject: WIP disk failure: forced shutdown of replicas .. WIP disk

[kudu-CR] disk failure: error-handling macros in blocks

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7030 to look at the new patch set (#16). Change subject: disk failure: error-handling macros in blocks .. disk failure:

[kudu-CR] disk failure: reassign failed tablets

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7440 to look at the new patch set (#4). Change subject: disk failure: reassign failed tablets .. disk failure: reassign

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 13: Pushed a fix to unblock Todds iterative testing. Will follow up for a fix to the multibuild

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7258 to look at the new patch set (#14). Change subject: KUDU-2066. Add experimental Gradle build support

[kudu-CR] thirdparty: use ninja when possible

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: thirdparty: use ninja when possible .. thirdparty: use ninja when possible Using ninja to build LLVM, etc, is a bit faster than using make, and produces

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 13: Code-Review+1 lgtm as a starting point. seems to be some issue still with running tests in

[kudu-CR] Integrate Mustache templates to webserver

2017-07-24 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#12). Change subject: Integrate Mustache templates to webserver .. Integrate

[kudu-CR] Integrate Mustache templates to webserver

2017-07-24 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#11). Change subject: Integrate Mustache templates to webserver .. Integrate

[kudu-CR] Integrate Mustache templates to webserver

2017-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Integrate Mustache templates to webserver .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7448/9/src/kudu/server/webserver.cc File

[kudu-CR] [rpc] WIP: Introduce configurable options to Messenger

2017-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] WIP: Introduce configurable options to Messenger .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6520/1/src/kudu/rpc/messenger.cc File

[kudu-CR] Integrate Mustache templates to webserver

2017-07-24 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7448 to look at the new patch set (#10). Change subject: Integrate Mustache templates to webserver .. Integrate

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7258 to look at the new patch set (#13). Change subject: KUDU-2066. Add experimental Gradle build support

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7258/11/java/gradle/wrapper.gradle File

[kudu-CR] WIP disk failure: error-handling macros in blocks

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7030 to look at the new patch set (#15). Change subject: WIP disk failure: error-handling macros in blocks .. WIP disk

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7258/11/java/gradle/wrapper.gradle File

[kudu-CR] disk failure: coordinate error handling

2017-07-24 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#22). Change subject: disk failure: coordinate error handling .. disk failure:

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7258 to look at the new patch set (#12). Change subject: KUDU-2066. Add experimental Gradle build support

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 2: (1 comment)

[kudu-CR] [WIP]log block manager:mark container as 'read only' after syncing error

2017-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [WIP]log block manager:mark container as 'read_only' after syncing error .. Patch Set 8: (13 comments) http://gerrit.cloudera.org:8080/#/c/7374/8//COMMIT_MSG

[kudu-CR] KUDU-1865: Avoid heap allocation for payload slices

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1865: Avoid heap allocation for payload slices .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7471/1/src/kudu/rpc/inbound_call.h File

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradle/wrapper.gradle File

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7258 to look at the new patch set (#11). Change subject: KUDU-2066. Add experimental Gradle build support

[kudu-CR] KUDU-2066. Add experimental Gradle build support

2017-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradle/wrapper.gradle File

[kudu-CR] Integrate Mustache templates to webserver

2017-07-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Integrate Mustache templates to webserver .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/7448/9/src/kudu/server/webserver.cc File

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2017-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 2: (1 comment) this looks like a possible source of the problem. not