[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#9). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] WIP [rpc] don't issue authn tokens over non-confidential connections

2018-01-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9025 Change subject: WIP [rpc] don't issue authn tokens over non-confidential connections .. WIP [rpc] don't issue authn tokens over

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#8). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 4: (1 comment)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2018-01-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 5: Code-Review+2 -- To view,

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. [raft_consensus-itest] proper fix for Test_KUDU_1735

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tools: Add debug mode to pb dump tool

2018-01-12 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9024 to review the following change. Change subject: tools: Add debug mode to pb dump tool .. tools: Add debug mode to pb

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#7). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. Patch Set 6: Code-Review+2 Carrying over Todd's +2 (just

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. KUDU-2253 Deltafile on-disk size is 3x larger than

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

2018-01-12 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

2018-01-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Patch Set 1: Verified+1 One ASAN test timed out in

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

2018-01-12 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9021 to review the following change. Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug .. Patch Set

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#6). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. Patch Set 3: (5 comments)

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8989 to look at the new patch set (#4). Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8982 to look at the new patch set (#6). Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. Patch Set 3: (5 comments) looks good, just some small nits

[kudu-CR] [docs] Removed the note about KUDU-1626

2018-01-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9020 Change subject: [docs] Removed the note about KUDU-1626 .. [docs] Removed the note about KUDU-1626 Change-Id:

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8982 to look at the new patch set (#5). Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8982 to look at the new patch set (#4). Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug .. Patch Set 5: (5

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 14: Code-Review+1 --

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-12 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8948 to look at the new patch set (#14). Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 13: > (1 comment) > (1

[kudu-CR] [docs] Added steps to update HMS after migrating to multiple Kudu masters

2018-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8948 ) Change subject: [docs] Added steps to update HMS after migrating to multiple Kudu masters .. Patch Set 13: (1 comment)

[kudu-CR] Kudu-2208 Avoid system call interruption in Subprocess

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9011 ) Change subject: Kudu-2208 Avoid system call interruption in Subprocess .. Patch Set 1: (12 comments)

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#5). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

[kudu-CR] consensus: Fix KUDU-1735 regression test in 3-4-3 mode

2018-01-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9013 ) Change subject: consensus: Fix KUDU-1735 regression test in 3-4-3 mode .. Patch Set 1: > Uploaded patch set 1. I integrated and

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8989 ) Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735 .. Patch Set 3: > I posted a rough sketch of a fix and an

[kudu-CR] [raft consensus-itest] proper fix for Test KUDU 1735

2018-01-12 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8989 to look at the new patch set (#3). Change subject: [raft_consensus-itest] proper fix for Test_KUDU_1735

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 ) Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2253 Deltafile on-disk size is 3x larger than expected

2018-01-12 Thread Dan Burkert (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8982 to look at the new patch set (#3). Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected

[kudu-CR] KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug

2018-01-12 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#3). Change subject: KUDU-2208 Add unit test to detect Subprocess Interruption Handling failure and patch to fix the bug