[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#8). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Yeah, i will rebase on master after this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Oh, I think you still need to rebase. -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Code-Review+1 LGTM but I will let Adar review

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#7). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: (7 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: Overall looks good to me structurally, some nits

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 3: (6 comments) a few comments, more are coming

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 5: (1 comment)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#5). Change subject: util: pull Random methods out from tests

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 4: (1 comment)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 4: (2 comments)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#4). Change subject: util: pull Random methods out from tests

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Patch Set 2: Verified+1 Overriding Jenkins, more flakes. -- To

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. dist_test.py: support --collect-tmpdir in Java tests

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12924 ) Change subject: dist_test.py: support --collect-tmpdir in Java tests .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12925 ) Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12925 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness

[kudu-CR](branch-1.9.x) [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12925 Change subject: [docs] Update known issues docs for location awareness .. [docs] Update known issues docs for location awareness Removes

[kudu-CR] [docs] Update known issues docs for location awareness

2019-04-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awareness .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] dist test.py: support --collect-tmpdir in Java tests

2019-04-03 Thread Adar Dembo (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12924 to review the following change. Change subject: dist_test.py: support --collect-tmpdir in Java tests ..

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: Note: This has a merge conflict. You should

[kudu-CR] build: enable Java flaky test reporting

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. build: enable Java flaky test reporting This patch moves flaky test

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. java: ensure KuduTestHarness or RetryRule in every

[kudu-CR] [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [docs] Update known issues docs for location awareness .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12920 To

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: Verified+1 More unknown Java

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Removed reviewer Kudu Jenkins with the

[kudu-CR] [docs] Update known issues docs for location awareness

2019-04-03 Thread Grant Henke (Code Review)
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12920 to look at the new patch set (#2). Change subject: [docs] Update known issues docs for location awareness

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] add document for KUDU-2080

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12774 ) Change subject: add document for KUDU-2080 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12774 To

[kudu-CR] [docs] Update known issues docs for location awarness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (3 comments)

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12917 to look at the new patch set (#3). Change subject: build: adapt new Java flaky test infrastructure to existing controls

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (1 comment)

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 3: (1 comment)

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 2: Verified+1 A Java test failed, but

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Removed reviewer Kudu Jenkins with the

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12917 to look at the new patch set (#2). Change subject: build: adapt new Java flaky test infrastructure to existing controls

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (6 comments)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 3: (1 comment)

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 ) Change subject: util: pull Random methods out from tests .. Patch Set 3: (2 comments)

[kudu-CR] [metrics] Remove incorrect comments

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12921 ) Change subject: [metrics] Remove incorrect comments .. Patch Set 1: (2 comments)

[kudu-CR] [docs] Update known issues docs for location awarness

2019-04-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (4 comments)

[kudu-CR] [metrics] Remove incorrect comments

2019-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12921 Change subject: [metrics] Remove incorrect comments .. [metrics] Remove incorrect comments Data store in std::map with key type 'const

[kudu-CR] util: pull Random methods out from tests

2019-04-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12918 to look at the new patch set (#3). Change subject: util: pull Random methods out from tests .. util: pull Random

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-03 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12919 to look at the new patch set (#3). Change subject: sentry: sanitize and parse privileges from Sentry ..

[kudu-CR] [docs] Update known issues docs for location awarness

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12920 ) Change subject: [docs] Update known issues docs for location awarness .. Patch Set 1: (1 comment)

[kudu-CR] build: adapt new Java flaky test infrastructure to existing controls

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12917 ) Change subject: build: adapt new Java flaky test infrastructure to existing controls .. Patch Set 1: (6 comments)

[kudu-CR] java: add support for flaky test reporting

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 ) Change subject: java: add support for flaky test reporting .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] build: enable Java flaky test reporting

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 ) Change subject: build: enable Java flaky test reporting .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 ) Change subject: java: ensure KuduTestHarness or RetryRule in every test .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments) Thank you for all the work on this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#6). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#5). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 4: Sorry for quickly retriggering the builder :( -- To

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#4). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 3: (3 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#3). Change subject: java/c++: ColumnSchema supports storing column comment