[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14630

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [metrics] Add metric severity level .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14630 to look at the new patch set (#5). Change subject: [metrics] Add metric severity level

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (2 comments)

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (1 comment)

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (1 comment) Pretty neat! LGTM overall

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (1 comment)

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14642 ) Change subject: [master] KUDU-2904 Crash master on disk error .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14642 to look at the new patch set (#3). Change subject: [master] KUDU-2904 Crash master on disk error

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14642 ) Change subject: [master] KUDU-2904 Crash master on disk error .. Patch Set 2: (2 comments)

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14642 ) Change subject: [master] KUDU-2904 Crash master on disk error .. Patch Set 1: (2 comments) Test looks good overall! I'd try looping

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14642 to look at the new patch set (#2). Change subject: [master] KUDU-2904 Crash master on disk error

[kudu-CR] [master] KUDU-2904 Crash master on disk error

2019-11-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14642 Change subject: [master] KUDU-2904 Crash master on disk error .. [master] KUDU-2904 Crash master on disk error Register disk failure

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.11.x) Update version to 1.11.1-SNAPSHOT

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14639 ) Change subject: Update version to 1.11.1-SNAPSHOT .. Update version to 1.11.1-SNAPSHOT Change-Id:

[kudu-CR](branch-1.11.x) Update version to 1.11.1-SNAPSHOT

2019-11-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14639 ) Change subject: Update version to 1.11.1-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14630 to look at the new patch set (#4). Change subject: [metrics] Add metric severity level

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 4: (5 comments)

[kudu-CR](branch-1.11.x) Update version to 1.11.1-SNAPSHOT

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14639 Change subject: Update version to 1.11.1-SNAPSHOT .. Update version to 1.11.1-SNAPSHOT Change-Id:

[kudu-CR](gh-pages) update website: add a note on KUDU-2990 for 1.11

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14638 Change subject: update website: add a note on KUDU-2990 for 1.11 .. update website: add a note on KUDU-2990 for 1.11 As discussed in

[kudu-CR](gh-pages) update website: add a note on KUDU-2990 for 1.11

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14638 ) Change subject: update website: add a note on KUDU-2990 for 1.11 .. update website: add a note on KUDU-2990 for 1.11 As

[kudu-CR](gh-pages) update website: add a note on KUDU-2990 for 1.11

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14638 ) Change subject: update website: add a note on KUDU-2990 for 1.11 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 3: > Patch Set 3: > > (5 comments) LGTM overall, left a few notes

[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony

2019-11-05 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14637 to look at the new patch set (#2). Change subject: [thirdparty] add license info about yaml-cpp and chrony

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 3: (5 comments)

[kudu-CR] [thirdparty] add license info about yaml-cpp and chrony

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14637 Change subject: [thirdparty] add license info about yaml-cpp and chrony .. [thirdparty] add license info about yaml-cpp and chrony

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 3: Verified+1 Documentation-only patch. -- To

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 3: Code-Review+2 Carrying over Andrew's +2 from

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. RELEASING: add instructions to create binary test

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 2: (2 comments)

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. RELEASING: add

[kudu-CR] KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

2019-11-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 ) Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime .. Patch Set 3: Code-Review+2 (2 comments)

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: [metrics] Add metric severity level .. Patch Set 1: (1 comment)

[kudu-CR] [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14630 to look at the new patch set (#3). Change subject: [metrics] Add metric severity level ..

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] WIP: [metrics] Add metric severity level

2019-11-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14630 to look at the new patch set (#2). Change subject: WIP: [metrics] Add metric severity level

[kudu-CR] KUDU-2977 Sharding block map to speed up tserver startup

2019-11-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 ) Change subject: KUDU-2977 Sharding block map to speed up tserver startup .. Patch Set 5: > Patch Set 5: > > The TSAN failure looks

[kudu-CR] KUDU-2977 Sharding block map to speed up tserver startup

2019-11-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 ) Change subject: KUDU-2977 Sharding block map to speed up tserver startup .. Patch Set 5: > Patch Set 5: > > The TSAN failure looks

[kudu-CR] KUDU-1260 Add test for prefetching on java scanner

2019-11-05 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14631 to look at the new patch set (#2). Change subject: KUDU-1260 Add test for prefetching on java scanner

[kudu-CR] KUDU-2987 Intra location rebalance will crash in special case.

2019-11-05 Thread ZhangYao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14608 to look at the new patch set (#3). Change subject: KUDU-2987 Intra location rebalance will crash in special case.

[kudu-CR] KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

2019-11-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, ye yuqiang, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14620 to look at the new patch set (#3). Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

[kudu-CR] KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

2019-11-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 ) Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime .. Patch Set 2: (1 comment) > > Thanks for

[kudu-CR] WIP: [metrics] Add metric severity level

2019-11-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 ) Change subject: WIP: [metrics] Add metric severity level .. Patch Set 1: (1 comment)