[kudu-CR] subprocess: use a pipe instead of stdout for IO

2020-03-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15574 to look at the new patch set (#2). Change subject: subprocess: use a pipe instead of stdout for IO

[kudu-CR] subprocess: use a pipe instead of stdout for IO

2020-03-27 Thread Andrew Wong (Code Review)
Hello Attila Bukor, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15574 to review the following change. Change subject: subprocess: use a pipe instead of stdout for IO

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 ) Change subject: status_callback: replace Bind usage with lambdas .. Patch Set 5: Code-Review+1 (2 comments)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 3: Code-Review+1 (5 comments)

[kudu-CR] KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15572 ) Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 ) Change subject: status_callback: replace Bind usage with lambdas .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (10 comments)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15572 ) Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

2020-03-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, huangtianhua...@gmail.com, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15572 to look at the new patch set (#2). Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15571 to look at the new patch set (#4). Change subject: log: clean up entry batch append callback usage

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Patch Set 4: (1 comment)

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15571 to look at the new patch set (#3). Change subject: log: clean up entry batch append callback usage

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 ) Change subject: status_callback: replace Bind usage with lambdas .. Patch Set 5: (2 comments)

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15571 ) Change subject: log: clean up entry batch append callback usage .. Patch Set 2: (1 comment)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15566 to look at the new patch set (#3). Change subject: [ranger] add more comments for Ranger privilege model

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15572 ) Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15562 ) Change subject: status_callback: replace Bind usage with lambdas .. Patch Set 4: (2 comments)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 2: (6 comments)

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15562 to look at the new patch set (#5). Change subject: status_callback: replace Bind usage with lambdas

[kudu-CR] log: clean up entry batch append callback usage

2020-03-27 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15571 to look at the new patch set (#2). Change subject: log: clean up entry batch append callback usage

[kudu-CR] KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

2020-03-27 Thread Adar Dembo (Code Review)
Hello huangtianhua...@gmail.com, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15572 to review the following change. Change subject: KUDU-3093: fix DebugUtilTest.TestSignalStackTrace in RELEASE mode

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 2: (6 comments)

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15566 to look at the new patch set (#2). Change subject: [ranger] add more comments for Ranger privilege model

[kudu-CR] [subprocess] remove conflict Jersey dependencies

2020-03-27 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15565 ) Change subject: [subprocess] remove conflict Jersey dependencies .. [subprocess] remove conflict Jersey dependencies In

[kudu-CR] log: pass append callback by value and std::move

2020-03-27 Thread Adar Dembo (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15571 to review the following change. Change subject: log: pass append callback by value and std::move .. log: pass append

[kudu-CR] iwyu: standardize on libc++

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. iwyu: standardize on libc++ A common IWYU pain point is that the set of

[kudu-CR] status callback: replace Bind usage with lambdas

2020-03-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15562 to look at the new patch set (#3). Change subject: status_callback: replace Bind usage with lambdas

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15543 ) Change subject: iwyu: codebase-wide fixes based on libcpp .. iwyu: codebase-wide fixes based on libcpp These were generated by

[kudu-CR] [ranger] add more comments for Ranger privilege model

2020-03-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 ) Change subject: [ranger] add more comments for Ranger privilege model .. Patch Set 1: (6 comments)

[kudu-CR] [subprocess] remove conflict Jersey dependencies

2020-03-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15565 ) Change subject: [subprocess] remove conflict Jersey dependencies .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15560 ) Change subject: Add functionality to serialize a RowBlock into columnar format .. Patch Set 5: (7 comments)

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. KUDU-3085: Create Scala/SBT integration test example.

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. Patch Set 4: > Patch Set 3: > > I still see them. Maybe a

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Brian McDevitt (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15535 to look at the new patch set (#4). Change subject: KUDU-3085: Create Scala/SBT integration test example.

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. Patch Set 3: I still see them. Maybe a mistake amending the

[kudu-CR] KUDU-3085: Create Scala/SBT integration test example.

2020-03-27 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 ) Change subject: KUDU-3085: Create Scala/SBT integration test example. .. Patch Set 3: > Patch Set 2: > > (1 comment) > > Looks good.